You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/24 17:36:33 UTC
[GitHub] [flink-connector-aws] hlteoh37 opened a new pull request, #29: [FLINK-29895] Further increase unit test coverage for DynamoDbSink
hlteoh37 opened a new pull request, #29:
URL: https://github.com/apache/flink-connector-aws/pull/29
## What is the purpose of the change
- Further increased test coverage for DynamoDbSink
- Refactor DynamoDbSinkWriter to provide the client via constructor so that we can test logic in `DynamoDbSinkWriter` without relying on an IT case.
## Verifying this change
- Built locally with unit and integration tests. Both pass
- Manually tested datastream and Table API using examples provided.
## Does this pull request potentially affect one of the following parts:
* Dependencies (does it add or upgrade a dependency): no
* The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
* The serializers: no
* The runtime per-record code paths (performance sensitive): no
* Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
* The S3 file system connector: no
## Documentation
* Does this pull request introduce a new feature? no
* If yes, how is the feature documented? n/a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] dannycranmer merged pull request #29: [FLINK-29895] Further increase unit test coverage for DynamoDbSink
Posted by GitBox <gi...@apache.org>.
dannycranmer merged PR #29:
URL: https://github.com/apache/flink-connector-aws/pull/29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] dannycranmer commented on a diff in pull request #29: [FLINK-29895] Further increase unit test coverage for DynamoDbSink
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on code in PR #29:
URL: https://github.com/apache/flink-connector-aws/pull/29#discussion_r1032260627
##########
flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/sink/client/DynamoDbAsyncClientProvider.java:
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.dynamodb.sink.client;
+
+import org.apache.flink.connector.aws.config.AWSConfigConstants;
+import org.apache.flink.connector.aws.util.AWSAsyncSinkUtil;
+import org.apache.flink.connector.aws.util.AWSGeneralUtil;
+import org.apache.flink.connector.dynamodb.sink.DynamoDbConfigConstants;
+
+import software.amazon.awssdk.http.async.SdkAsyncHttpClient;
+import software.amazon.awssdk.services.dynamodb.DynamoDbAsyncClient;
+
+import java.util.Properties;
+
+/** Provides a {@link DynamoDbAsyncClient}. */
+public class DynamoDbAsyncClientProvider implements SdkClientProvider<DynamoDbAsyncClient> {
Review Comment:
Please make this `@Internal`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org