[GitHub] [kafka] Comonut opened a new pull request #10516: KAFKA-12555 - Log all reason for rolling a segment

[GitBox <gi...@apache.org>]

Comonut opened a new pull request #10516:
URL: https://github.com/apache/kafka/pull/10516


   The original ticket was to debug log the reason for rolling a new log segment.
   based on LogSegment.shouldRoll, there are 5 conditions for rolling:
   
   1. Segment exceeds max byte size
   2. Segment exceeds time limit
   3. Offset index is full
   4. Timestamp index is full
   5. The offsets can no longer be converted to relative offsets
   
   And the first 4 were already trackable from the existing debug log message, but 5 was missing so I'm suggesting to add it in the existing one. 
   There was also an extra `}`  that's a typo in the log string  that I've removed. 
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] Comonut closed pull request #10516: KAFKA-12555 - Log all reason for rolling a segment

[GitBox <gi...@apache.org>]

Comonut closed pull request #10516:
URL: https://github.com/apache/kafka/pull/10516


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org