You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Jason Altekruse <al...@gmail.com> on 2014/01/04 19:14:46 UTC

Re: Review Request 14207: Drill 238

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14207/
-----------------------------------------------------------

(Updated Jan. 4, 2014, 6:14 p.m.)


Review request for drill.


Changes
-------

Just a note, I created a new JIRA to record the need for reorganizing and consolidating the parquet tests. This new patch incorporates that work as well. The patch is dependent on the Parquet changes made for column based read, but the diff for that has been included here as a dependency so I believe downloading the diff here should give you the complete change-set necessary for it to apply cleanly against the tip of master.


Bugs: bug, fields, nullable, and parquet
    https://issues.apache.org/jira/browse/bug
    https://issues.apache.org/jira/browse/fields
    https://issues.apache.org/jira/browse/nullable
    https://issues.apache.org/jira/browse/parquet


Repository: drill-git


Description
-------

Fix bug described in Drill 238.


Diffs (updated)
-----

  exec/java-exec/src/test/java/org/apache/drill/exec/store/CachedSingleFileSystem.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/ParquetRecordReaderTest.java 733cb1d 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/TestOutputMutator.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/FieldInfo.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetRecordReaderTest.java ab29a9f 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetResultListener.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetTestProperties.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestFileGenerator.java d2c95fe 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/WrapAroundCounter.java PRE-CREATION 

Diff: https://reviews.apache.org/r/14207/diff/


Testing
-------

Full mvn clean install, some tests that required pig generated file referenced in the jira.


Thanks,

Jason Altekruse


Re: Review Request 14207: Drill 238

Posted by Jason Altekruse <al...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14207/
-----------------------------------------------------------

(Updated Jan. 16, 2014, 5:03 p.m.)


Review request for drill.


Changes
-------

Rebased changes on update to parent patch.


Bugs: bug, fields, nullable, and parquet
    https://issues.apache.org/jira/browse/bug
    https://issues.apache.org/jira/browse/fields
    https://issues.apache.org/jira/browse/nullable
    https://issues.apache.org/jira/browse/parquet


Repository: drill-git


Description
-------

Fix bug described in Drill 238.


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/store/json/JSONRecordReader.java 49aea22 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/VarLenBinaryReader.java 276a4df 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/CachedSingleFileSystem.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/ParquetRecordReaderTest.java 733cb1d 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/TestOutputMutator.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/FieldInfo.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetRecordReaderTest.java ab29a9f 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetResultListener.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetTestProperties.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestFileGenerator.java d2c95fe 
  exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/WrapAroundCounter.java PRE-CREATION 

Diff: https://reviews.apache.org/r/14207/diff/


Testing
-------

Full mvn clean install, some tests that required pig generated file referenced in the jira.


Thanks,

Jason Altekruse