You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/05/10 23:42:39 UTC
[GitHub] [ozone] hanishakoneru opened a new pull request #2234: HDDS-5164. Improve client and server logging.
hanishakoneru opened a new pull request #2234:
URL: https://github.com/apache/ozone/pull/2234
## What changes were proposed in this pull request?
On the OM server side, NotLeaderException and LeaderNotReadyExceptions can be suppressed. Otherwise, OM1 log is flooded with NotLeaderExceptions as clients always try OM1 before moving to the next OM. Instead we can change these exception logs to DEBUG.
Some BlockOutputStream and BlockOutputStreamEntryPool logs should be DEBUG level instead of INFO. For example, block allocation with an exclude list need not be logged at INFO level.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5164
## How was this patch tested?
No new tests. Changing only LOG levels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on pull request #2234: HDDS-5164. Improve client and server logging.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on pull request #2234:
URL: https://github.com/apache/ozone/pull/2234#issuecomment-839455278
Thank You @hanishakoneru for the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2234: HDDS-5164. Improve client and server logging.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #2234:
URL: https://github.com/apache/ozone/pull/2234#discussion_r629873977
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java
##########
@@ -193,6 +193,15 @@ private OMResponse submitReadRequestToOM(OMRequest request)
}
}
+ private ServiceException createLeaderErrorException(
Review comment:
Minor: Unnecessary code change. I see it is just moved up.
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -883,6 +885,10 @@ private static StorageContainerLocationProtocol getScmContainerClient(
false)) {
rpcServer.refreshServiceAcl(conf, OMPolicyProvider.getInstance());
}
+
+ rpcServer.addSuppressedLoggingExceptions(OMNotLeaderException.class,
Review comment:
Good find, so now on server side Rpc does not log these errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] hanishakoneru commented on a change in pull request #2234: HDDS-5164. Improve client and server logging.
Posted by GitBox <gi...@apache.org>.
hanishakoneru commented on a change in pull request #2234:
URL: https://github.com/apache/ozone/pull/2234#discussion_r630357146
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -883,6 +885,10 @@ private static StorageContainerLocationProtocol getScmContainerClient(
false)) {
rpcServer.refreshServiceAcl(conf, OMPolicyProvider.getInstance());
}
+
+ rpcServer.addSuppressedLoggingExceptions(OMNotLeaderException.class,
Review comment:
Yes, otherwise we see a lot of noise - "om1 is not the leader" exceptions, on the server side logs if the 1st OM is not the leader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] hanishakoneru commented on pull request #2234: HDDS-5164. Improve client and server logging.
Posted by GitBox <gi...@apache.org>.
hanishakoneru commented on pull request #2234:
URL: https://github.com/apache/ozone/pull/2234#issuecomment-839914774
Thank you @bharatviswa504
>I am fine with it, but one thing with this is we will lose which commit originally added this. (As sometimes I check why this code is added/changed to understand the reason for this code change. This is just my personal opinion.)
Makes sense. I did not consider this aspect. I will keep this in mind in future. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 merged pull request #2234: HDDS-5164. Improve client and server logging.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 merged pull request #2234:
URL: https://github.com/apache/ozone/pull/2234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] hanishakoneru commented on a change in pull request #2234: HDDS-5164. Improve client and server logging.
Posted by GitBox <gi...@apache.org>.
hanishakoneru commented on a change in pull request #2234:
URL: https://github.com/apache/ozone/pull/2234#discussion_r630356252
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java
##########
@@ -193,6 +193,15 @@ private OMResponse submitReadRequestToOM(OMRequest request)
}
}
+ private ServiceException createLeaderErrorException(
Review comment:
Yes functionally no change. Moved it up for aesthetics and improving code readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2234: HDDS-5164. Improve client and server logging.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #2234:
URL: https://github.com/apache/ozone/pull/2234#discussion_r630734630
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java
##########
@@ -193,6 +193,15 @@ private OMResponse submitReadRequestToOM(OMRequest request)
}
}
+ private ServiceException createLeaderErrorException(
Review comment:
I am fine with it, but one thing with this is we will lose which commit originally added this. (As sometimes I check why this code is added/changed to understand the reason for this code change. This is just my personal opinion.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org