You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by we...@apache.org on 2015/06/18 22:23:13 UTC
[2/3] incubator-reef git commit: [REEF-388]: Fix violations of
RedundantModifier checkstyle
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/utils/ExceptionCodec.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/utils/ExceptionCodec.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/utils/ExceptionCodec.java
index f1e1a66..ffbc3d0 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/utils/ExceptionCodec.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/utils/ExceptionCodec.java
@@ -33,18 +33,18 @@ public interface ExceptionCodec {
* @param bytes
* @return the Throable or Optional.empty() if the deserialization fails.
*/
- public Optional<Throwable> fromBytes(final byte[] bytes);
+ Optional<Throwable> fromBytes(final byte[] bytes);
/**
* @param bytes
* @return fromBytes(bytes.get()) or Optional.empty()
*/
- public Optional<Throwable> fromBytes(final Optional<byte[]> bytes);
+ Optional<Throwable> fromBytes(final Optional<byte[]> bytes);
/**
* @param throwable
* @return the serialized form of the given Throwable.
*/
- public byte[] toBytes(final Throwable throwable);
+ byte[] toBytes(final Throwable throwable);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/task/Task.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/task/Task.java b/lang/java/reef-common/src/main/java/org/apache/reef/task/Task.java
index fd0bc58..e41f6a8 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/task/Task.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/task/Task.java
@@ -42,5 +42,5 @@ public interface Task {
* @throws Exception whenever the Task encounters an unsolved issue.
* This Exception will be thrown at the Driver's event handler.
*/
- public byte[] call(final byte[] memento) throws Exception;
+ byte[] call(final byte[] memento) throws Exception;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/task/TaskMessageSource.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/task/TaskMessageSource.java b/lang/java/reef-common/src/main/java/org/apache/reef/task/TaskMessageSource.java
index 1424c03..2c4525e 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/task/TaskMessageSource.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/task/TaskMessageSource.java
@@ -35,5 +35,5 @@ public interface TaskMessageSource {
/**
* @return a message to be sent back to the Driver, or Optional.empty() if no message shall be sent at this time.
*/
- public Optional<TaskMessage> getMessage();
+ Optional<TaskMessage> getMessage();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/task/events/CloseEvent.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/task/events/CloseEvent.java b/lang/java/reef-common/src/main/java/org/apache/reef/task/events/CloseEvent.java
index b22b523..fc0aada 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/task/events/CloseEvent.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/task/events/CloseEvent.java
@@ -34,5 +34,5 @@ public interface CloseEvent {
/**
* @return the message sent with the close call, if any.
*/
- public Optional<byte[]> get();
+ Optional<byte[]> get();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/task/events/DriverMessage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/task/events/DriverMessage.java b/lang/java/reef-common/src/main/java/org/apache/reef/task/events/DriverMessage.java
index 56fcdce..dbcff98 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/task/events/DriverMessage.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/task/events/DriverMessage.java
@@ -34,5 +34,5 @@ public interface DriverMessage {
/**
* @return the message sent by the driver.
*/
- public Optional<byte[]> get();
+ Optional<byte[]> get();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/task/events/SuspendEvent.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/task/events/SuspendEvent.java b/lang/java/reef-common/src/main/java/org/apache/reef/task/events/SuspendEvent.java
index 7e8d880..8b1f929 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/task/events/SuspendEvent.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/task/events/SuspendEvent.java
@@ -34,5 +34,5 @@ public interface SuspendEvent {
/**
* @return the message sent with the suspend call, if any.
*/
- public Optional<byte[]> get();
+ Optional<byte[]> get();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/task/events/TaskStop.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/task/events/TaskStop.java b/lang/java/reef-common/src/main/java/org/apache/reef/task/events/TaskStop.java
index ca8542e..ecbe475 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/task/events/TaskStop.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/task/events/TaskStop.java
@@ -32,5 +32,5 @@ public interface TaskStop extends Identifiable {
/**
* @return the task identifier
*/
- public String getId();
+ String getId();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/util/Builder.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/Builder.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/Builder.java
index 0a70677..29a55ab 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/util/Builder.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/Builder.java
@@ -31,5 +31,5 @@ public interface Builder<T> {
*
* @return a fresh instance of the object.
*/
- public T build();
+ T build();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/util/CommandUtils.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/CommandUtils.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/CommandUtils.java
index 54db4f8..55d7eed 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/util/CommandUtils.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/CommandUtils.java
@@ -33,7 +33,7 @@ final public class CommandUtils {
*/
private static final Logger LOG = Logger.getLogger(CommandUtils.class.getName());
- public final static String runCommand(final String command) {
+ public static String runCommand(final String command) {
final StringBuilder sb = new StringBuilder();
try {
final String cmd = OSUtils.isWindows() ? "cmd.exe /c " + command : command;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LoggingScope.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LoggingScope.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LoggingScope.java
index 2f2a7f3..820d12f 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LoggingScope.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LoggingScope.java
@@ -25,5 +25,5 @@ package org.apache.reef.util.logging;
public interface LoggingScope extends AutoCloseable {
@Override
- public void close();
+ void close();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloDriver.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloDriver.java b/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloDriver.java
index 33f60a3..18f4623 100644
--- a/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloDriver.java
+++ b/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloDriver.java
@@ -77,7 +77,7 @@ public final class HelloDriver {
* @return task configuration for the CLR Task.
* @throws BindException
*/
- private static final Configuration getCLRTaskConfiguration(final String taskId) throws BindException {
+ private static Configuration getCLRTaskConfiguration(final String taskId) throws BindException {
final ConfigurationBuilder taskConfigurationBuilder = Tang.Factory.getTang()
.newConfigurationBuilder(loadClassHierarchy());
taskConfigurationBuilder.bind("Org.Apache.Reef.Tasks.TaskConfigurationOptions+Identifier,Org.Apache.Reef.Tasks.ITask, Version=1.0.0.0, Culture=neutral, PublicKeyToken=69c3241e6f0468ca", taskId);
@@ -108,7 +108,7 @@ public final class HelloDriver {
*
* @param allocatedEvaluator
*/
- final void onNextCLR(final AllocatedEvaluator allocatedEvaluator) {
+ void onNextCLR(final AllocatedEvaluator allocatedEvaluator) {
try {
allocatedEvaluator.setProcess(clrProcessFactory.newEvaluatorProcess());
final Configuration contextConfiguration = ContextConfiguration.CONF
@@ -130,7 +130,7 @@ public final class HelloDriver {
*
* @param allocatedEvaluator
*/
- final void onNextJVM(final AllocatedEvaluator allocatedEvaluator) {
+ void onNextJVM(final AllocatedEvaluator allocatedEvaluator) {
try {
final Configuration contextConfiguration = ContextConfiguration.CONF
.set(ContextConfiguration.IDENTIFIER, "HelloREEFContext")
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDClient.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDClient.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDClient.java
index d43d27f..bf75239 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDClient.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDClient.java
@@ -88,7 +88,7 @@ public class BGDClient {
return DriverLauncher.getLauncher(runtimeConfiguration).run(driverConfiguration, timeout);
}
- private final Configuration getDriverConfiguration(final String jobName) {
+ private Configuration getDriverConfiguration(final String jobName) {
return Configurations.merge(
getDataLoadConfiguration(jobName),
GroupCommService.getConfiguration(fanOut),
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/data/parser/Parser.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/data/parser/Parser.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/data/parser/Parser.java
index 2987fde..c0f92c1 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/data/parser/Parser.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/data/parser/Parser.java
@@ -27,6 +27,6 @@ import org.apache.reef.examples.group.bgd.data.Example;
*/
public interface Parser<T> {
- public Example parse(final T input);
+ Example parse(final T input);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/Vector.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/Vector.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/Vector.java
index f91e693..b5e86ba 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/Vector.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/Vector.java
@@ -31,14 +31,14 @@ public interface Vector extends ImmutableVector, Serializable {
* @param i the index
* @param v value
*/
- public void set(final int i, final double v);
+ void set(final int i, final double v);
/**
* Adds the Vector that to this one in place: this += that.
*
* @param that
*/
- public void add(final Vector that);
+ void add(final Vector that);
/**
* this += factor * that.
@@ -46,20 +46,20 @@ public interface Vector extends ImmutableVector, Serializable {
* @param factor
* @param that
*/
- public void multAdd(final double factor, final ImmutableVector that);
+ void multAdd(final double factor, final ImmutableVector that);
/**
* Scales this Vector: this *= factor.
*
* @param factor the scaling factor.
*/
- public void scale(final double factor);
+ void scale(final double factor);
/**
* Normalizes the Vector according to the L2 norm.
*/
- public void normalize();
+ void normalize();
/**
* Create a new instance of the current type.
@@ -67,6 +67,6 @@ public interface Vector extends ImmutableVector, Serializable {
*
* @return zero vector of current dimensionality
*/
- public Vector newInstance();
+ Vector newInstance();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloTask.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloTask.java
index 17bce48..5c0b8ec 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloTask.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloTask.java
@@ -32,7 +32,7 @@ public final class HelloTask implements Task {
}
@Override
- public final byte[] call(final byte[] memento) {
+ public byte[] call(final byte[] memento) {
System.out.println("Hello, REEF!");
return null;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java
index 1733ad8..9d40c63 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java
@@ -55,7 +55,7 @@ public final class SchedulerREEF {
/**
* @return The http configuration to use reef-webserver
*/
- private final static Configuration getHttpConf() {
+ private static Configuration getHttpConf() {
final Configuration httpHandlerConf = HttpHandlerConfiguration.CONF
.set(HttpHandlerConfiguration.HTTP_HANDLERS, SchedulerHttpHandler.class)
.build();
@@ -65,7 +65,7 @@ public final class SchedulerREEF {
/**
* @return The Driver configuration.
*/
- private final static Configuration getDriverConf() {
+ private static Configuration getDriverConf() {
final Configuration driverConf = DriverConfiguration.CONF
.set(DriverConfiguration.GLOBAL_LIBRARIES, EnvironmentUtils.getClassLocation(SchedulerDriver.class))
.set(DriverConfiguration.DRIVER_IDENTIFIER, "TaskScheduler")
@@ -104,7 +104,7 @@ public final class SchedulerREEF {
* @param args
* @throws InjectionException
*/
- public final static void main(String[] args) throws InjectionException, IOException, ParseException {
+ public static void main(String[] args) throws InjectionException, IOException, ParseException {
final Configuration runtimeConfiguration = LocalRuntimeConfiguration.CONF
.set(LocalRuntimeConfiguration.MAX_NUMBER_OF_EVALUATORS, MAX_NUMBER_OF_EVALUATORS)
.build();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java
index 3bdacfc..1a462e1 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java
@@ -37,7 +37,7 @@ public final class SchedulerREEFYarn {
* @throws InjectionException
* @throws java.io.IOException
*/
- public final static void main(String[] args)
+ public static void main(String[] args)
throws InjectionException, IOException, ParseException {
final Configuration runtimeConfiguration =
YarnClientConfiguration.CONF.build();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendDriver.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendDriver.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendDriver.java
index 5ae5009..a016529 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendDriver.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendDriver.java
@@ -145,7 +145,7 @@ public class SuspendDriver {
*/
final class RunningTaskHandler implements EventHandler<RunningTask> {
@Override
- public final void onNext(final RunningTask task) {
+ public void onNext(final RunningTask task) {
LOG.log(Level.INFO, "Running task: {0}", task.getId());
runningTasks.put(task.getId(), task);
jobMessageObserver.sendMessageToClient(CODEC_STR.encode("start task: " + task.getId()));
@@ -157,7 +157,7 @@ public class SuspendDriver {
*/
final class CompletedTaskHandler implements EventHandler<CompletedTask> {
@Override
- public final void onNext(final CompletedTask task) {
+ public void onNext(final CompletedTask task) {
final EvaluatorDescriptor e = task.getActiveContext().getEvaluatorDescriptor();
final String msg = "Task completed " + task.getId() + " on node " + e;
@@ -186,7 +186,7 @@ public class SuspendDriver {
*/
final class SuspendedTaskHandler implements EventHandler<SuspendedTask> {
@Override
- public final void onNext(final SuspendedTask task) {
+ public void onNext(final SuspendedTask task) {
final String msg = "Task suspended: " + task.getId();
LOG.info(msg);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-examples/src/main/java/org/apache/reef/examples/utils/wake/BlockingEventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/utils/wake/BlockingEventHandler.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/utils/wake/BlockingEventHandler.java
index 59967d8..07fb635 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/utils/wake/BlockingEventHandler.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/utils/wake/BlockingEventHandler.java
@@ -42,7 +42,7 @@ public final class BlockingEventHandler<T> implements EventHandler<T> {
}
@Override
- public final void onNext(final T event) {
+ public void onNext(final T event) {
if (this.isComplete()) {
throw new IllegalStateException("Received more Events than expected");
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-io/src/main/java/org/apache/reef/io/network/ConnectionFactory.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/ConnectionFactory.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/ConnectionFactory.java
index 8590aee..3f5b1b8 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/ConnectionFactory.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/ConnectionFactory.java
@@ -33,5 +33,5 @@ public interface ConnectionFactory<T> {
* @param destId a destination identifier
* @return a connection
*/
- public Connection<T> newConnection(Identifier destId);
+ Connection<T> newConnection(Identifier destId);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/CommunicationGroupDriver.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/CommunicationGroupDriver.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/CommunicationGroupDriver.java
index 3b9194c..3c5bfa2 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/CommunicationGroupDriver.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/CommunicationGroupDriver.java
@@ -42,7 +42,7 @@ public interface CommunicationGroupDriver {
* @param spec
* @return
*/
- public CommunicationGroupDriver addBroadcast(Class<? extends Name<String>> operatorName, BroadcastOperatorSpec spec);
+ CommunicationGroupDriver addBroadcast(Class<? extends Name<String>> operatorName, BroadcastOperatorSpec spec);
/**
* Add the reduce operator specified by the.
@@ -53,7 +53,7 @@ public interface CommunicationGroupDriver {
* @param spec
* @return
*/
- public CommunicationGroupDriver addReduce(Class<? extends Name<String>> operatorName, ReduceOperatorSpec spec);
+ CommunicationGroupDriver addReduce(Class<? extends Name<String>> operatorName, ReduceOperatorSpec spec);
/**
* This signals to the service that no more.
@@ -61,7 +61,7 @@ public interface CommunicationGroupDriver {
* group and an attempt to do that will throw an
* IllegalStateException
*/
- public void finalise();
+ void finalise();
/**
* Returns a configuration that includes the partial task
@@ -73,7 +73,7 @@ public interface CommunicationGroupDriver {
* @param taskConf
* @return
*/
- public Configuration getTaskConfiguration(Configuration taskConf);
+ Configuration getTaskConfiguration(Configuration taskConf);
/**
* Add the task represented by this configuration to this
@@ -82,5 +82,5 @@ public interface CommunicationGroupDriver {
*
* @param partialTaskConf
*/
- public void addTask(Configuration partialTaskConf);
+ void addTask(Configuration partialTaskConf);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/TaskNodeStatus.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/TaskNodeStatus.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/TaskNodeStatus.java
index 41a2e07..ef72d3f 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/TaskNodeStatus.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/TaskNodeStatus.java
@@ -55,7 +55,7 @@ public interface TaskNodeStatus {
* As this is called from the TaskNodeImpl use srcId of msg
* In TaskNodeImpl while processMsg use dstId of msg
*/
- public void expectAckFor(final Type msgType, final String srcId);
+ void expectAckFor(final Type msgType, final String srcId);
/**
* Used when the task has failed to clear all.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Broadcast.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Broadcast.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Broadcast.java
index 0b133cb..6054c23 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Broadcast.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Broadcast.java
@@ -36,7 +36,7 @@ public interface Broadcast {
* Sender or Root.
*/
@DefaultImplementation(BroadcastSender.class)
- static interface Sender<T> extends GroupCommOperator {
+ interface Sender<T> extends GroupCommOperator {
/**
* Send element to all receivers.
@@ -48,7 +48,7 @@ public interface Broadcast {
* Receivers or Non-roots.
*/
@DefaultImplementation(BroadcastReceiver.class)
- static interface Receiver<T> extends GroupCommOperator {
+ interface Receiver<T> extends GroupCommOperator {
/**
* Receiver the element broadcasted by sender.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Gather.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Gather.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Gather.java
index a31336d..dc356d7 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Gather.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Gather.java
@@ -34,7 +34,7 @@ public interface Gather {
/**
* Senders or non-roots.
*/
- static interface Sender<T> extends GroupCommOperator {
+ interface Sender<T> extends GroupCommOperator {
/**
* Send the element to the root/receiver.
@@ -45,7 +45,7 @@ public interface Gather {
/**
* Receiver or Root.
*/
- static interface Receiver<T> extends GroupCommOperator {
+ interface Receiver<T> extends GroupCommOperator {
/**
* Receive the elements sent by the senders in default order.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Reduce.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Reduce.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Reduce.java
index 98fc2b6..76688eb 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Reduce.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Reduce.java
@@ -39,7 +39,7 @@ public interface Reduce {
* Receiver or Root.
*/
@DefaultImplementation(ReduceReceiver.class)
- static interface Receiver<T> extends GroupCommOperator {
+ interface Receiver<T> extends GroupCommOperator {
/**
* Receive values sent by senders and pass them through the reduce
@@ -69,7 +69,7 @@ public interface Reduce {
* Senders or non roots.
*/
@DefaultImplementation(ReduceSender.class)
- static interface Sender<T> extends GroupCommOperator {
+ interface Sender<T> extends GroupCommOperator {
/**
* Send the element to the root.
@@ -88,7 +88,7 @@ public interface Reduce {
* Interface for a Reduce Function takes in an {@link Iterable} returns an.
* aggregate value computed from the {@link Iterable}
*/
- static interface ReduceFunction<T> {
+ interface ReduceFunction<T> {
/**
* Apply the function on elements.
*
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Scatter.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Scatter.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Scatter.java
index 20b65c9..5dba002 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Scatter.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/operators/Scatter.java
@@ -35,7 +35,7 @@ public interface Scatter {
/**
* Sender or Root.
*/
- static interface Sender<T> extends GroupCommOperator {
+ interface Sender<T> extends GroupCommOperator {
/**
* Distributes evenly across task ids sorted lexicographically.
@@ -63,7 +63,7 @@ public interface Scatter {
/**
* Receiver or non-roots.
*/
- static interface Receiver<T> extends GroupCommOperator {
+ interface Receiver<T> extends GroupCommOperator {
/**
* Receive the sub-list of elements targeted for the current receiver.
*
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServer.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServer.java
index 21bd1e2..0625b4c 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServer.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServer.java
@@ -35,7 +35,7 @@ public interface NameServer extends Stage {
* get port number.
* @return
*/
- public int getPort();
+ int getPort();
/**
* Registers an (identifier, address) mapping locally.
@@ -43,14 +43,14 @@ public interface NameServer extends Stage {
* @param id an identifier
* @param addr an Internet socket address
*/
- public void register(final Identifier id, final InetSocketAddress addr);
+ void register(final Identifier id, final InetSocketAddress addr);
/**
* Unregisters an identifier locally.
*
* @param id an identifier
*/
- public void unregister(final Identifier id);
+ void unregister(final Identifier id);
/**
* Finds an address for an identifier locally.
@@ -58,7 +58,7 @@ public interface NameServer extends Stage {
* @param id an identifier
* @return an Internet socket address
*/
- public InetSocketAddress lookup(final Identifier id);
+ InetSocketAddress lookup(final Identifier id);
/**
* Finds addresses for identifiers locally.
@@ -66,5 +66,5 @@ public interface NameServer extends Stage {
* @param identifiers an Iterable of identifiers
* @return a list of name assignments
*/
- public List<NameAssignment> lookup(final Iterable<Identifier> identifiers);
+ List<NameAssignment> lookup(final Iterable<Identifier> identifiers);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/AvroUtils.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/AvroUtils.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/AvroUtils.java
index 81f9b14..ce9bcc5 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/AvroUtils.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/AvroUtils.java
@@ -41,7 +41,7 @@ final class AvroUtils {
* @param <T>
* @return
*/
- static final <T> byte[] toBytes(T avroObject, Class<T> theClass) {
+ static <T> byte[] toBytes(T avroObject, Class<T> theClass) {
final DatumWriter<T> datumWriter = new SpecificDatumWriter<>(theClass);
final byte[] theBytes;
try (final ByteArrayOutputStream out = new ByteArrayOutputStream()) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/HDICLI.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/HDICLI.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/HDICLI.java
index 2c928f4..8991fa1 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/HDICLI.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/HDICLI.java
@@ -63,7 +63,7 @@ public final class HDICLI {
/**
* Helper method to setup apache commons logging.
*/
- private static final void setupLogging() {
+ private static void setupLogging() {
System.setProperty("org.apache.commons.logging.Log", "org.apache.commons.logging.impl.Jdk14Logger");
System.setProperty(".level", "INFO");
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/LogFileEntry.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/LogFileEntry.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/LogFileEntry.java
index d1f2928..311ef94 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/LogFileEntry.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/LogFileEntry.java
@@ -75,7 +75,7 @@ final class LogFileEntry {
* @param outputWriter
* @throws IOException
*/
- private final void writeFiles(final DataInputStream valueStream, final Writer outputWriter) throws IOException {
+ private void writeFiles(final DataInputStream valueStream, final Writer outputWriter) throws IOException {
while (valueStream.available() > 0) {
final String strFileName = valueStream.readUTF();
final int entryLength = Integer.parseInt(valueStream.readUTF());
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/HDInsightJobSubmissionHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/HDInsightJobSubmissionHandler.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/HDInsightJobSubmissionHandler.java
index 0c7219b..151c9a1 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/HDInsightJobSubmissionHandler.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/HDInsightJobSubmissionHandler.java
@@ -124,7 +124,7 @@ public final class HDInsightJobSubmissionHandler implements JobSubmissionHandler
/**
* Extracts the resource demands from the jobSubmissionEvent.
*/
- private final Resource getResource(
+ private Resource getResource(
final JobSubmissionEvent jobSubmissionEvent) {
return new Resource()
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/HDInsightInstance.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/HDInsightInstance.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/HDInsightInstance.java
index 5894c8c..e4b0bce 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/HDInsightInstance.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/HDInsightInstance.java
@@ -168,7 +168,7 @@ public final class HDInsightInstance {
return "ws/v1/cluster/apps/" + applicationId;
}
- private final String getHost() throws URISyntaxException {
+ private String getHost() throws URISyntaxException {
final URI uri = new URI(this.instanceUrl);
return uri.getHost();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/FileSet.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/FileSet.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/FileSet.java
index a00c4a5..f80fb04 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/FileSet.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/FileSet.java
@@ -46,7 +46,7 @@ final class FileSet {
*
* @param file the file to be added.
*/
- final void add(final File file) {
+ void add(final File file) {
if (file.isFile()) {
if (this.fileNames.contains(file.getName())) {
LOG.log(Level.FINEST, "A file with this name has already been added: {0}", file.getName());
@@ -59,14 +59,14 @@ final class FileSet {
}
}
- final boolean containsFileWithName(final String name) {
+ boolean containsFileWithName(final String name) {
return this.fileNames.contains(name);
}
/**
* @return an iterable over the filenames, sans the folder. e.g. "/tmp/foo.txt" is returned as "foo.txt"
*/
- final Set<String> fileNames() {
+ Set<String> fileNames() {
return this.fileNames;
}
@@ -76,7 +76,7 @@ final class FileSet {
* @param destinationFolder the folder where the files shall be copied to.
* @throws IOException
*/
- final void copyTo(final File destinationFolder) throws IOException {
+ void copyTo(final File destinationFolder) throws IOException {
for (final File f : this.theFiles) {
final File destinationFile = new File(destinationFolder, f.getName());
Files.copy(f.toPath(), destinationFile.toPath(), java.nio.file.StandardCopyOption.REPLACE_EXISTING);
@@ -89,7 +89,7 @@ final class FileSet {
* @param destinationFolder the folder where the symbolic links will be created.
* @throws IOException
*/
- final void createSymbolicLinkTo(final File destinationFolder) throws IOException {
+ void createSymbolicLinkTo(final File destinationFolder) throws IOException {
for (final File f : this.theFiles) {
final File destinationFile = new File(destinationFolder, f.getName());
Files.createSymbolicLink(destinationFile.toPath(), f.toPath());
@@ -103,7 +103,7 @@ final class FileSet {
* @param field the field to add the files in this set to.
* @return the filled out ConfigurationModule
*/
- final ConfigurationModule addNamesTo(final ConfigurationModule input, final OptionalParameter<String> field) {
+ ConfigurationModule addNamesTo(final ConfigurationModule input, final OptionalParameter<String> field) {
ConfigurationModule result = input;
for (final String fileName : this.fileNames()) {
result = result.set(field, fileName);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java
index 7e20d32..03ad267 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java
@@ -77,12 +77,12 @@ final class LocalJobSubmissionHandler implements JobSubmissionHandler {
}
@Override
- public final void close() {
+ public void close() {
this.executor.shutdown();
}
@Override
- public final void onNext(final JobSubmissionEvent t) {
+ public void onNext(final JobSubmissionEvent t) {
try (final LoggingScope lf = loggingScopeFactory.localJobSubmission()) {
try {
LOG.log(Level.FINEST, "Starting local job {0}", t.getIdentifier());
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/Container.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/Container.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/Container.java
index ff1f9b8..5b77b26 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/Container.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/Container.java
@@ -36,50 +36,50 @@ interface Container extends AutoCloseable {
*
* @param commandLine the command line to execute. It will typically be joined by spaces to form the command line.
*/
- public void run(final List<String> commandLine);
+ void run(final List<String> commandLine);
/**
* Copies the files to the working directory of the container.
*
* @param files the files to be added to the container.
*/
- public void addLocalFiles(final Iterable<File> files);
+ void addLocalFiles(final Iterable<File> files);
- public void addGlobalFiles(final File globalFolder);
+ void addGlobalFiles(final File globalFolder);
/**
* @return true if the Container is currently executing, false otherwise.
*/
- public boolean isRunning();
+ boolean isRunning();
/**
* @return the ID of the node this Container is executing on.
*/
- public String getNodeID();
+ String getNodeID();
/**
* @return the ID of this Container.
*/
- public String getContainerID();
+ String getContainerID();
/**
* @return the main memory available to the Container.
*/
- public int getMemory();
+ int getMemory();
/**
* @return the core available to the Container.
*/
- public int getNumberOfCores();
+ int getNumberOfCores();
/**
* @return the working directory of the Container.
*/
- public File getFolder();
+ File getFolder();
/**
* Kills the Container.
*/
@Override
- public void close();
+ void close();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ContainerManager.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ContainerManager.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ContainerManager.java
index 918e1d1..8a98087 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ContainerManager.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ContainerManager.java
@@ -141,11 +141,11 @@ final class ContainerManager implements AutoCloseable {
}
}
- final boolean hasContainerAvailable() {
+ boolean hasContainerAvailable() {
return this.freeNodeList.size() > 0;
}
- final Container allocateOne(final int megaBytes, final int numberOfCores) {
+ Container allocateOne(final int megaBytes, final int numberOfCores) {
synchronized (this.containers) {
final String nodeId = this.freeNodeList.remove(0);
final String processID = nodeId + "-" + String.valueOf(System.currentTimeMillis());
@@ -159,7 +159,7 @@ final class ContainerManager implements AutoCloseable {
}
}
- final void release(final String containerID) {
+ void release(final String containerID) {
synchronized (this.containers) {
final Container ctr = this.containers.get(containerID);
if (null != ctr) {
@@ -175,7 +175,7 @@ final class ContainerManager implements AutoCloseable {
}
}
- final Container get(final String containedID) {
+ Container get(final String containedID) {
synchronized (this.containers) {
return this.containers.get(containedID);
}
@@ -184,7 +184,7 @@ final class ContainerManager implements AutoCloseable {
/**
* @return a List of the IDs of currently allocated Containers.
*/
- final Iterable<String> getAllocatedContainerIDs() {
+ Iterable<String> getAllocatedContainerIDs() {
return this.containers.keySet();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/IDMaker.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/IDMaker.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/IDMaker.java
index cf415c4..bfaeeef 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/IDMaker.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/IDMaker.java
@@ -40,7 +40,7 @@ public final class IDMaker {
/**
* @return the next ID
*/
- public final String getNextID() {
+ public String getNextID() {
this.counter += 1;
return this.prefix + this.counter;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ProcessContainer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ProcessContainer.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ProcessContainer.java
index 8a428c3..da5d157 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ProcessContainer.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ProcessContainer.java
@@ -129,17 +129,17 @@ final class ProcessContainer implements Container {
}
@Override
- public final boolean isRunning() {
+ public boolean isRunning() {
return null != this.theThread && this.theThread.isAlive();
}
@Override
- public final int getMemory() {
+ public int getMemory() {
return this.megaBytes;
}
@Override
- public final int getNumberOfCores() {
+ public int getNumberOfCores() {
return this.numberOfCores;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceManager.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceManager.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceManager.java
index b3979f7..8d9656b 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceManager.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceManager.java
@@ -124,7 +124,7 @@ public final class ResourceManager {
*
* @param resourceRequest the resource request to be handled.
*/
- final void onResourceRequest(final ResourceRequestEvent resourceRequest) {
+ void onResourceRequest(final ResourceRequestEvent resourceRequest) {
synchronized (this.theContainers) {
this.requestQueue.add(new ResourceRequest(resourceRequest));
this.checkRequestQueue();
@@ -136,7 +136,7 @@ public final class ResourceManager {
*
* @param releaseRequest the release request to be processed
*/
- final void onResourceReleaseRequest(final ResourceReleaseEvent releaseRequest) {
+ void onResourceReleaseRequest(final ResourceReleaseEvent releaseRequest) {
synchronized (this.theContainers) {
LOG.log(Level.FINEST, "Release container: {0}", releaseRequest.getIdentifier());
this.theContainers.release(releaseRequest.getIdentifier());
@@ -149,7 +149,7 @@ public final class ResourceManager {
*
* @param evaluatorId the ID of the Evaluator that exited.
*/
- public final void onEvaluatorExit(final String evaluatorId) {
+ public void onEvaluatorExit(final String evaluatorId) {
synchronized (this.theContainers) {
this.theContainers.release(evaluatorId);
this.checkRequestQueue();
@@ -161,7 +161,7 @@ public final class ResourceManager {
*
* @param launchRequest the launch request to be processed.
*/
- final void onResourceLaunchRequest(
+ void onResourceLaunchRequest(
final ResourceLaunchEvent launchRequest) {
synchronized (this.theContainers) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceRequest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceRequest.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceRequest.java
index 6fd8f39..a55e2f3 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceRequest.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceRequest.java
@@ -42,7 +42,7 @@ final class ResourceRequest {
/**
* Records that one resource has been allocated to this Request.
*/
- final void satisfyOne() {
+ void satisfyOne() {
this.satisfied += 1;
if (this.satisfied > req.getResourceCount()) {
throw new IllegalStateException("This request has been oversatisfied.");
@@ -53,11 +53,11 @@ final class ResourceRequest {
* @return true if the request is satisfied with this additional unit of
* resource, false otherwise.
*/
- final boolean isSatisfied() {
+ boolean isSatisfied() {
return this.satisfied == req.getResourceCount();
}
- final ResourceRequestEvent getRequestProto() {
+ ResourceRequestEvent getRequestProto() {
return this.req;
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceRequestQueue.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceRequestQueue.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceRequestQueue.java
index 7ab7e09..898f3c7 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceRequestQueue.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceRequestQueue.java
@@ -39,14 +39,14 @@ final class ResourceRequestQueue {
*
* @param req the request to be added.
*/
- final void add(final ResourceRequest req) {
+ void add(final ResourceRequest req) {
this.requestQueue.add(req);
}
/**
* @return true if there are outstanding resource requests. false otherwise.
*/
- final boolean hasOutStandingRequests() {
+ boolean hasOutStandingRequests() {
return !this.requestQueue.isEmpty();
}
@@ -54,7 +54,7 @@ final class ResourceRequestQueue {
* Satisfies one resource for the front-most request. If that satisfies the
* request, it is removed from the queue.
*/
- final synchronized ResourceRequestEvent satisfyOne() {
+ synchronized ResourceRequestEvent satisfyOne() {
final ResourceRequest req = this.requestQueue.element();
req.satisfyOne();
if (req.isSatisfied()) {
@@ -63,7 +63,7 @@ final class ResourceRequestQueue {
return req.getRequestProto();
}
- final synchronized int getNumberOfOutstandingRequests() {
+ synchronized int getNumberOfOutstandingRequests() {
return this.requestQueue.size();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/process/RunnableProcessObserver.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/process/RunnableProcessObserver.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/process/RunnableProcessObserver.java
index 4db6500..b8a366a 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/process/RunnableProcessObserver.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/process/RunnableProcessObserver.java
@@ -27,7 +27,7 @@ public interface RunnableProcessObserver {
*
* @param processId the id of the process that started.
*/
- public void onProcessStarted(final String processId);
+ void onProcessStarted(final String processId);
/**
* This will be called right after the process exited.
@@ -35,5 +35,5 @@ public interface RunnableProcessObserver {
* @param exitCode the return code of the process.
* @param processId the id of the process that exited.
*/
- public void onProcessExit(final String processId, final int exitCode);
+ void onProcessExit(final String processId, final int exitCode);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/evaluator/REEFExecutor.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/evaluator/REEFExecutor.java b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/evaluator/REEFExecutor.java
index eb5f340..81d52fe 100644
--- a/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/evaluator/REEFExecutor.java
+++ b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/evaluator/REEFExecutor.java
@@ -82,7 +82,7 @@ public final class REEFExecutor implements Executor {
}
@Override
- public final void registered(final ExecutorDriver driver,
+ public void registered(final ExecutorDriver driver,
final ExecutorInfo executorInfo,
final FrameworkInfo frameworkInfo,
final SlaveInfo slaveInfo) {
@@ -91,12 +91,12 @@ public final class REEFExecutor implements Executor {
}
@Override
- public final void reregistered(final ExecutorDriver driver, final SlaveInfo slaveInfo) {
+ public void reregistered(final ExecutorDriver driver, final SlaveInfo slaveInfo) {
LOG.log(Level.FINEST, "Executor reregistered. driver: {0}", driver);
}
@Override
- public final void disconnected(final ExecutorDriver driver) {
+ public void disconnected(final ExecutorDriver driver) {
this.onRuntimeError();
}
@@ -104,7 +104,7 @@ public final class REEFExecutor implements Executor {
* We assume a long-running Mesos Task that manages a REEF Evaluator process, leveraging Mesos Executor's interface.
*/
@Override
- public final void launchTask(final ExecutorDriver driver, final TaskInfo task) {
+ public void launchTask(final ExecutorDriver driver, final TaskInfo task) {
driver.sendStatusUpdate(TaskStatus.newBuilder()
.setTaskId(TaskID.newBuilder().setValue(this.mesosExecutorId).build())
.setState(TaskState.TASK_STARTING)
@@ -114,23 +114,23 @@ public final class REEFExecutor implements Executor {
}
@Override
- public final void killTask(final ExecutorDriver driver, final TaskID taskId) {
+ public void killTask(final ExecutorDriver driver, final TaskID taskId) {
this.onStop();
}
@Override
- public final void frameworkMessage(final ExecutorDriver driver, final byte[] data) {
+ public void frameworkMessage(final ExecutorDriver driver, final byte[] data) {
LOG.log(Level.FINEST, "Framework Messge. ExecutorDriver: {0}, data: {1}.",
new Object[]{driver, data});
}
@Override
- public final void shutdown(final ExecutorDriver driver) {
+ public void shutdown(final ExecutorDriver driver) {
this.onStop();
}
@Override
- public final void error(final ExecutorDriver driver, final String message) {
+ public void error(final ExecutorDriver driver, final String message) {
this.onRuntimeError();
}
@@ -190,13 +190,13 @@ public final class REEFExecutor implements Executor {
this.mesosExecutorDriver.stop();
}
- public final void onEvaluatorRelease(final EvaluatorRelease evaluatorRelease) {
+ public void onEvaluatorRelease(final EvaluatorRelease evaluatorRelease) {
LOG.log(Level.INFO, "Release!!!! {0}", evaluatorRelease.toString());
assert(evaluatorRelease.getIdentifier().toString().equals(this.mesosExecutorId));
this.onStop();
}
- public final void onEvaluatorLaunch(final EvaluatorLaunch evaluatorLaunch) {
+ public void onEvaluatorLaunch(final EvaluatorLaunch evaluatorLaunch) {
LOG.log(Level.INFO, "Launch!!!! {0}", evaluatorLaunch.toString());
assert(evaluatorLaunch.getIdentifier().toString().equals(this.mesosExecutorId));
final ExecutorService evaluatorLaunchExecutorService = Executors.newSingleThreadExecutor();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnJobSubmissionHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnJobSubmissionHandler.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnJobSubmissionHandler.java
index a5e02ff..d340448 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnJobSubmissionHandler.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnJobSubmissionHandler.java
@@ -143,8 +143,8 @@ final class YarnJobSubmissionHandler implements JobSubmissionHandler {
* <p/>
* TODO: Revisit this. We also have a named parameter for the queue in YarnClientConfiguration.
*/
- private final String getQueue(final JobSubmissionEvent jobSubmissionEvent,
- final String defaultQueue) {
+ private String getQueue(final JobSubmissionEvent jobSubmissionEvent,
+ final String defaultQueue) {
return jobSubmissionEvent.getQueue().orElse(defaultQueue);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/TrackingURLProvider.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/TrackingURLProvider.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/TrackingURLProvider.java
index ba8f369..068abd6 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/TrackingURLProvider.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/TrackingURLProvider.java
@@ -25,5 +25,5 @@ import org.apache.reef.tang.annotations.DefaultImplementation;
*/
@DefaultImplementation(DefaultTrackingURLProvider.class)
public interface TrackingURLProvider {
- public String getTrackingUrl();
+ String getTrackingUrl();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerManager.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerManager.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerManager.java
index 1efbbf6..5aeddea 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerManager.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerManager.java
@@ -114,14 +114,14 @@ final class YarnContainerManager
}
@Override
- public final void onContainersCompleted(final List<ContainerStatus> containerStatuses) {
+ public void onContainersCompleted(final List<ContainerStatus> containerStatuses) {
for (final ContainerStatus containerStatus : containerStatuses) {
onContainerStatus(containerStatus);
}
}
@Override
- public final void onContainersAllocated(final List<Container> containers) {
+ public void onContainersAllocated(final List<Container> containers) {
// ID is used for logging only
final String id = String.format("%s:%d",
@@ -153,17 +153,17 @@ final class YarnContainerManager
}
@Override
- public final float getProgress() {
+ public float getProgress() {
return 0; // TODO: return actual values for progress
}
@Override
- public final void onError(final Throwable throwable) {
+ public void onError(final Throwable throwable) {
onRuntimeError(throwable);
}
@Override
- public final void onContainerStarted(
+ public void onContainerStarted(
final ContainerId containerId, final Map<String, ByteBuffer> stringByteBufferMap) {
final Optional<Container> container = this.containers.getOptional(containerId.toString());
if (container.isPresent()) {
@@ -172,13 +172,13 @@ final class YarnContainerManager
}
@Override
- public final void onContainerStatusReceived(
+ public void onContainerStatusReceived(
final ContainerId containerId, final ContainerStatus containerStatus) {
onContainerStatus(containerStatus);
}
@Override
- public final void onContainerStopped(final ContainerId containerId) {
+ public void onContainerStopped(final ContainerId containerId) {
final boolean hasContainer = this.containers.hasContainer(containerId.toString());
if (hasContainer) {
final ResourceStatusEventImpl.Builder resourceStatusBuilder =
@@ -189,19 +189,19 @@ final class YarnContainerManager
}
@Override
- public final void onStartContainerError(
+ public void onStartContainerError(
final ContainerId containerId, final Throwable throwable) {
handleContainerError(containerId, throwable);
}
@Override
- public final void onGetContainerStatusError(
+ public void onGetContainerStatusError(
final ContainerId containerId, final Throwable throwable) {
handleContainerError(containerId, throwable);
}
@Override
- public final void onStopContainerError(
+ public void onStopContainerError(
final ContainerId containerId, final Throwable throwable) {
handleContainerError(containerId, throwable);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/util/YarnTypes.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/util/YarnTypes.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/util/YarnTypes.java
index 8c96ece..536d7b5 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/util/YarnTypes.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/util/YarnTypes.java
@@ -39,7 +39,7 @@ public final class YarnTypes {
/**
* @return a ContainerLaunchContext with the given commands and LocalResources.
*/
- public static final ContainerLaunchContext getContainerLaunchContext(
+ public static ContainerLaunchContext getContainerLaunchContext(
final List<String> commands, final Map<String, LocalResource> localResources) {
final ContainerLaunchContext context = Records.newRecord(ContainerLaunchContext.class);
context.setLocalResources(localResources);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/BindLocation.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/BindLocation.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/BindLocation.java
index 1e65982..3ae638b 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/BindLocation.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/BindLocation.java
@@ -34,5 +34,5 @@ public interface BindLocation {
* trace, configuration file location, or other source of some
* configuration data.
*/
- public abstract String toString();
+ String toString();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ClassHierarchy.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ClassHierarchy.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ClassHierarchy.java
index 8a95e1e..4833717 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ClassHierarchy.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ClassHierarchy.java
@@ -44,12 +44,12 @@ public interface ClassHierarchy {
* @throws NameResolutionException If the class is not found.
* @throws ClassHierarchyException If the class does not pass Tang's static analysis.
*/
- public Node getNode(String fullName) throws NameResolutionException;
+ Node getNode(String fullName) throws NameResolutionException;
/**
* @return true if impl is a subclass of inter.
*/
- public boolean isImplementation(ClassNode<?> inter, ClassNode<?> impl);
+ boolean isImplementation(ClassNode<?> inter, ClassNode<?> impl);
/**
* Merge the contents of this ClassHierarchy and the provided one into a new
@@ -64,7 +64,7 @@ public interface ClassHierarchy {
* ClassHierarchies derived from applications written in different languages
* cannot be merged.
*/
- public ClassHierarchy merge(ClassHierarchy ch);
+ ClassHierarchy merge(ClassHierarchy ch);
/**
* Return a reference to the root of the ClassHierarchy. This is needed by
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Configuration.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Configuration.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Configuration.java
index 69229e9..ded80fa 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Configuration.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Configuration.java
@@ -69,7 +69,7 @@ public interface Configuration {
* This API is unstable and should be considered private. Use the methods
* in org.apache.reef.Tang instead.
*/
- public ConfigurationBuilder newBuilder();
+ ConfigurationBuilder newBuilder();
/**
* Return the value of the given named parameter as an unparsed string.
@@ -81,7 +81,7 @@ public interface Configuration {
* @return The validated string that this parameter is bound to, or null.
* @see getClassHierarchy()
*/
- public String getNamedParameter(NamedParameterNode<?> np);
+ String getNamedParameter(NamedParameterNode<?> np);
/**
* Obtain the set of class hierarchy nodes or strings that were bound to a given NamedParameterNode.
@@ -91,7 +91,7 @@ public interface Configuration {
* @return A set of ClassHierarchy Node objects or a set of strings, depending on whether the NamedParameterNode refers to an interface or configuration options, respectively.
* @see getClassHierarchy()
*/
- public Set<Object> getBoundSet(NamedParameterNode<Set<?>> np);
+ Set<Object> getBoundSet(NamedParameterNode<Set<?>> np);
/**
* Get the list bound to a given NamedParameterNode. The list will be empty if nothing was bound.
@@ -99,17 +99,17 @@ public interface Configuration {
* @param np Target NamedParameter
* @return A list bound to np
*/
- public List<Object> getBoundList(NamedParameterNode<List<?>> np);
+ List<Object> getBoundList(NamedParameterNode<List<?>> np);
/**
* @return the external constructor that cn has been explicitly bound to, or null. Defaults are not returned.
*/
- public <T> ClassNode<ExternalConstructor<T>> getBoundConstructor(ClassNode<T> cn);
+ <T> ClassNode<ExternalConstructor<T>> getBoundConstructor(ClassNode<T> cn);
/**
* @return the implementation that cn has been explicitly bound to, or null. Defaults are not returned.
*/
- public <T> ClassNode<T> getBoundImplementation(ClassNode<T> cn);
+ <T> ClassNode<T> getBoundImplementation(ClassNode<T> cn);
/**
* Return the LegacyConstructor that has been bound to this Class. Such constructors are defined in the class, but missing their @Inject annotation.
@@ -118,7 +118,7 @@ public interface Configuration {
* <p/>
* TODO: Should this return Set<ConstructorDef<T>> instead?
*/
- public <T> ConstructorDef<T> getLegacyConstructor(ClassNode<T> cn);
+ <T> ConstructorDef<T> getLegacyConstructor(ClassNode<T> cn);
/**
* @return the set of all interfaces (or super-classes) that have been explicitly
@@ -146,7 +146,7 @@ public interface Configuration {
*
* @return the ClassHierarchy that backs this Configuration.
*/
- public ClassHierarchy getClassHierarchy();
+ ClassHierarchy getClassHierarchy();
/**
* Get the set bindings from set-valued NamedParameters to the values they were bound to.
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ConfigurationBuilder.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ConfigurationBuilder.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ConfigurationBuilder.java
index 3c43fb0..f56ee0e 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ConfigurationBuilder.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ConfigurationBuilder.java
@@ -73,7 +73,7 @@ public interface ConfigurationBuilder {
*
* @param c
*/
- public void addConfiguration(final Configuration c) throws BindException;
+ void addConfiguration(final Configuration c) throws BindException;
/**
* Each ConfigurationBuilder instance is associated with a ClassHierarchy.
@@ -84,7 +84,7 @@ public interface ConfigurationBuilder {
* ConfigurationBuilder. No copy is made, since ClassHierarchy objects
* are effectively immutable.
*/
- public ClassHierarchy getClassHierarchy();
+ ClassHierarchy getClassHierarchy();
/**
* Force Tang to treat the specified constructor as though it had an @Inject
@@ -142,7 +142,7 @@ public interface ConfigurationBuilder {
* and values) if iface is not a NamedParameter, or if impl
* fails to parse as the type the iface expects.
*/
- public <T> void bind(String iface, String impl)
+ <T> void bind(String iface, String impl)
throws BindException;
/**
@@ -189,21 +189,21 @@ public interface ConfigurationBuilder {
* @param impl The ExternalConstructor class that will be used to instantiate iface.
* @throws BindException If impl does not instantiate a subclass of iface.
*/
- public <T> void bindConstructor(ClassNode<T> iface,
- ClassNode<? extends ExternalConstructor<? extends T>> impl)
+ <T> void bindConstructor(ClassNode<T> iface,
+ ClassNode<? extends ExternalConstructor<? extends T>> impl)
throws BindException;
/**
* Pretty print the default implementation / value of the provided class / NamedParamter.
* This is used by Tang to produce human readable error messages.
*/
- public String classPrettyDefaultString(String longName) throws BindException;
+ String classPrettyDefaultString(String longName) throws BindException;
/**
* Pretty print the human readable documentation of the provided class / NamedParamter.
* This is used by Tang to produce human readable error messages.
*/
- public String classPrettyDescriptionString(String longName)
+ String classPrettyDescriptionString(String longName)
throws BindException;
/**
@@ -218,17 +218,17 @@ public interface ConfigurationBuilder {
*
* @return
*/
- public Configuration build();
+ Configuration build();
- public <T> void bindSetEntry(NamedParameterNode<Set<T>> iface, Node impl)
+ <T> void bindSetEntry(NamedParameterNode<Set<T>> iface, Node impl)
throws BindException;
- public <T> void bindSetEntry(NamedParameterNode<Set<T>> iface, String impl)
+ <T> void bindSetEntry(NamedParameterNode<Set<T>> iface, String impl)
throws BindException;
- public void bindSetEntry(String iface, String impl) throws BindException;
+ void bindSetEntry(String iface, String impl) throws BindException;
- public void bindSetEntry(String iface, Node impl) throws BindException;
+ void bindSetEntry(String iface, Node impl) throws BindException;
/**
* Bind an list of implementations(Class or String) to an given NamedParameter.
@@ -244,8 +244,8 @@ public interface ConfigurationBuilder {
* @param implList The list of class or value will be used to instantiated the named parameter
* @throws BindException
*/
- public <T> void bindList(NamedParameterNode<List<T>> iface, List implList) throws BindException;
+ <T> void bindList(NamedParameterNode<List<T>> iface, List implList) throws BindException;
- public void bindList(String iface, List implList) throws BindException;
+ void bindList(String iface, List implList) throws BindException;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ExternalConstructor.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ExternalConstructor.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ExternalConstructor.java
index 08afd63..92c5220 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ExternalConstructor.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ExternalConstructor.java
@@ -36,5 +36,5 @@ public interface ExternalConstructor<T> {
*
* @return a new, distinct instance of T.
*/
- public T newInstance();
+ T newInstance();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/InjectionFuture.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/InjectionFuture.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/InjectionFuture.java
index c6ddde7..f576791 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/InjectionFuture.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/InjectionFuture.java
@@ -91,17 +91,17 @@ public final class InjectionFuture<T> implements Future<T> {
}
@Override
- public final boolean cancel(boolean mayInterruptIfRunning) {
+ public boolean cancel(boolean mayInterruptIfRunning) {
return false;
}
@Override
- public final boolean isCancelled() {
+ public boolean isCancelled() {
return false;
}
@Override
- public final boolean isDone() {
+ public boolean isDone() {
return true;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Injector.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Injector.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Injector.java
index cb708fd..fb472a4 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Injector.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Injector.java
@@ -37,9 +37,9 @@ public interface Injector {
* @throws NameResolutionException
* @throws ReflectiveOperationException
*/
- public <U> U getInstance(Class<U> iface) throws InjectionException;
+ <U> U getInstance(Class<U> iface) throws InjectionException;
- public <U> U getInstance(String iface) throws InjectionException,
+ <U> U getInstance(String iface) throws InjectionException,
NameResolutionException;
/**
@@ -51,7 +51,7 @@ public interface Injector {
* given interface class.
* @throws InjectionException
*/
- public <U> U getNamedInstance(Class<? extends Name<U>> iface)
+ <U> U getNamedInstance(Class<? extends Name<U>> iface)
throws InjectionException;
/**
@@ -65,10 +65,10 @@ public interface Injector {
* @return A copy of this injector that reflects the new binding.
* @throws BindException
*/
- public <T> void bindVolatileInstance(Class<T> iface, T inst)
+ <T> void bindVolatileInstance(Class<T> iface, T inst)
throws BindException;
- public <T> void bindVolatileParameter(Class<? extends Name<T>> iface, T inst)
+ <T> void bindVolatileParameter(Class<? extends Name<T>> iface, T inst)
throws BindException;
/**
@@ -81,7 +81,7 @@ public interface Injector {
* @param a
* @throws BindException
*/
- public <T> void bindAspect(Aspect a) throws BindException;
+ <T> void bindAspect(Aspect a) throws BindException;
/**
* Allows InjectionFuture to tell the aspect when get() is invoked. Package private.
@@ -107,7 +107,7 @@ public interface Injector {
* @throws BindException If any of the configurations conflict with each other, or the
* existing Injector's Configuration.
*/
- public Injector forkInjector(Configuration... configurations) throws BindException;
+ Injector forkInjector(Configuration... configurations) throws BindException;
/**
* Returns true if this Injector is able to instantiate the object named by
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaClassHierarchy.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaClassHierarchy.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaClassHierarchy.java
index 2456046..7523127 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaClassHierarchy.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaClassHierarchy.java
@@ -38,9 +38,9 @@ public interface JavaClassHierarchy extends ClassHierarchy {
* @param c The class to be looked up in the class hierarchy.
* @return The associated NamedParameterNode or ClassNode.
*/
- public Node getNode(Class<?> c);
+ Node getNode(Class<?> c);
- public Class<?> classForName(String name) throws ClassNotFoundException;
+ Class<?> classForName(String name) throws ClassNotFoundException;
/**
* Parse a string value that has been passed into a named parameter.
@@ -52,7 +52,7 @@ public interface JavaClassHierarchy extends ClassHierarchy {
* wrong type (such as when it specifies a class that does not implement
* or extend T).
*/
- public <T> T parse(NamedParameterNode<T> name, String value) throws ParseException;
+ <T> T parse(NamedParameterNode<T> name, String value) throws ParseException;
/**
* Obtain a parsed instance of the default value of a named parameter.
@@ -62,6 +62,6 @@ public interface JavaClassHierarchy extends ClassHierarchy {
* then this method returns a (potentially empty) set of default instances.
* @throws ClassHierarchyException if an instance failed to parse.
*/
- public <T> T parseDefaultValue(NamedParameterNode<T> name) throws ClassHierarchyException;
+ <T> T parseDefaultValue(NamedParameterNode<T> name) throws ClassHierarchyException;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaConfigurationBuilder.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaConfigurationBuilder.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaConfigurationBuilder.java
index 75b10b1..cf9d8a4 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaConfigurationBuilder.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/JavaConfigurationBuilder.java
@@ -47,7 +47,7 @@ public interface JavaConfigurationBuilder extends ConfigurationBuilder {
* @param iface
* @param impl
*/
- public <T> JavaConfigurationBuilder bind(Class<T> iface, Class<?> impl) throws BindException;
+ <T> JavaConfigurationBuilder bind(Class<T> iface, Class<?> impl) throws BindException;
/**
* Binds the Class impl as the implementation of the interface iface.
@@ -56,7 +56,7 @@ public interface JavaConfigurationBuilder extends ConfigurationBuilder {
* @param iface
* @param impl
*/
- public <T> JavaConfigurationBuilder bindImplementation(Class<T> iface, Class<? extends T> impl)
+ <T> JavaConfigurationBuilder bindImplementation(Class<T> iface, Class<? extends T> impl)
throws BindException;
@@ -68,18 +68,18 @@ public interface JavaConfigurationBuilder extends ConfigurationBuilder {
* how to parse the parameter's type.
* @throws org.apache.reef.tang.exceptions.NameResolutionException
*/
- public JavaConfigurationBuilder bindNamedParameter(Class<? extends Name<?>> name, String value)
+ JavaConfigurationBuilder bindNamedParameter(Class<? extends Name<?>> name, String value)
throws BindException;
- public <T> JavaConfigurationBuilder bindNamedParameter(Class<? extends Name<T>> iface,
- Class<? extends T> impl) throws BindException;
+ <T> JavaConfigurationBuilder bindNamedParameter(Class<? extends Name<T>> iface,
+ Class<? extends T> impl) throws BindException;
- public <T> JavaConfigurationBuilder bindConstructor(Class<T> c,
- Class<? extends ExternalConstructor<? extends T>> v) throws BindException;
+ <T> JavaConfigurationBuilder bindConstructor(Class<T> c,
+ Class<? extends ExternalConstructor<? extends T>> v) throws BindException;
- public <T> JavaConfigurationBuilder bindSetEntry(Class<? extends Name<Set<T>>> iface, String value) throws BindException;
+ <T> JavaConfigurationBuilder bindSetEntry(Class<? extends Name<Set<T>>> iface, String value) throws BindException;
- public <T> JavaConfigurationBuilder bindSetEntry(Class<? extends Name<Set<T>>> iface, Class<? extends T> impl) throws BindException;
+ <T> JavaConfigurationBuilder bindSetEntry(Class<? extends Name<Set<T>>> iface, Class<? extends T> impl) throws BindException;
/**
* Binds a specfic list to a named parameter. List's elements can be string values or class implementations.
@@ -92,6 +92,6 @@ public interface JavaConfigurationBuilder extends ConfigurationBuilder {
* @return
* @throws BindException
*/
- public <T> JavaConfigurationBuilder bindList(Class<? extends Name<List<T>>> iface, List impl)
+ <T> JavaConfigurationBuilder bindList(Class<? extends Name<List<T>>> iface, List impl)
throws BindException;
}