[GitHub] [pinot] walterddr commented on a diff in pull request #10451: Moving Zk updates for reload, force_commit to their own Znodes which …

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #10451:
URL: https://github.com/apache/pinot/pull/10451#discussion_r1155062021


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -255,6 +255,8 @@ public PinotHelixResourceManager(ControllerConf controllerConf) {
    * as PARTICIPANT,
    * which would be put to lead controller resource and mess up the leadership assignment. Those places should use
    * SPECTATOR other than PARTICIPANT.
+   * TODO:For the <a href="https://github.com/apache/pinot/pull/10451">backwards incompatible change</a>, this is a

Review Comment:
   is it possible that controller restart/upgrade occurred during a segment reload process is still in progress and can end up in a weird state?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org