You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/07/15 08:39:35 UTC

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #809: [INFRA] Support reopen pr in pr merge tool

pan3793 commented on a change in pull request #809:
URL: https://github.com/apache/incubator-kyuubi/pull/809#discussion_r670256977



##########
File path: dev/merge_kyuubi_pr.py
##########
@@ -252,7 +252,7 @@ def main():
     # Merged pull requests don't appear as merged in the GitHub API;
     # Instead, they're closed by asfgit.
     merge_commits = \
-        [e for e in pr_events if e["event"] == "closed"]
+        [e for e in pr_events if e["event"] == "closed" and e["commit_id"]]

Review comment:
       It's the key point.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org