You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Max Powers (JIRA)" <ji...@codehaus.org> on 2008/12/19 15:54:19 UTC
[jira] Created: (MNG-3927) readOnly parameters in a plugin are not
readOnly
readOnly parameters in a plugin are not readOnly
------------------------------------------------
Key: MNG-3927
URL: http://jira.codehaus.org/browse/MNG-3927
Project: Maven 2
Issue Type: Bug
Components: Plugins and Lifecycle
Affects Versions: 2.0.9
Reporter: Max Powers
Attachments: pom.xml
Seems that maven is allowing pom writers to define new values for parameters that a plugin has marked as readOnly. I have attached a pom that overrides the resources parameter in the maven-resources-plugin. This is allowed in 2.0.9, but fails (as it should) in 3.x (see line 89)
I would've expected to see this error (as i do in 3.x)
[ERROR]
ERROR: Cannot override read-only parameter: resources in goal: resources:resources
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3927) [regression] Configuration of custom
plugin execution using default id pollutes configuration of default plugin
executions introduced by packaging
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason van Zyl updated MNG-3927:
-------------------------------
Fix Version/s: (was: 3.0-alpha-4)
3.0-alpha-3
> [regression] Configuration of custom plugin execution using default id pollutes configuration of default plugin executions introduced by packaging
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MNG-3927
> URL: http://jira.codehaus.org/browse/MNG-3927
> Project: Maven 2
> Issue Type: Bug
> Components: Plugins and Lifecycle
> Affects Versions: 3.0-alpha-1
> Reporter: Max Powers
> Assignee: Brian Fox
> Fix For: 3.0-alpha-3
>
> Attachments: pom.xml
>
>
> Seems that maven is allowing pom writers to define new values for parameters that a plugin has marked as readOnly. I have attached a pom that overrides the resources parameter in the maven-resources-plugin. This is allowed in 2.0.9, but fails (as it should) in 3.x (see line 89)
> I would've expected to see this error (as i do in 3.x)
> [ERROR]
> ERROR: Cannot override read-only parameter: resources in goal: resources:resources
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MNG-3927) [regression] Configuration of custom
plugin execution using default id pollutes configuration of default plugin
executions introduced by packaging
Posted by "Shane Isbell (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shane Isbell closed MNG-3927.
-----------------------------
Resolution: Fixed
> [regression] Configuration of custom plugin execution using default id pollutes configuration of default plugin executions introduced by packaging
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MNG-3927
> URL: http://jira.codehaus.org/browse/MNG-3927
> Project: Maven 2
> Issue Type: Bug
> Components: Plugins and Lifecycle
> Affects Versions: 3.0-alpha-1
> Reporter: Max Powers
> Assignee: Shane Isbell
> Fix For: 3.0-alpha-3
>
> Attachments: pom.xml
>
>
> Seems that maven is allowing pom writers to define new values for parameters that a plugin has marked as readOnly. I have attached a pom that overrides the resources parameter in the maven-resources-plugin. This is allowed in 2.0.9, but fails (as it should) in 3.x (see line 89)
> I would've expected to see this error (as i do in 3.x)
> [ERROR]
> ERROR: Cannot override read-only parameter: resources in goal: resources:resources
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3927) [regression] Configuration of custom
plugin execution using default id pollutes configuration of default plugin
executions introduced by packaging
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann updated MNG-3927:
-----------------------------------
Affects Version/s: (was: 2.0.9)
3.0-alpha-1
Summary: [regression] Configuration of custom plugin execution using default id pollutes configuration of default plugin executions introduced by packaging (was: readOnly parameters in a plugin are not readOnly)
It's actually bug in Maven 3.x. The relevant part of Max's POM:
{code:xml}
<plugin>
<artifactId>maven-resources-plugin</artifactId>
<version>2.3</version>
<executions>
<execution>
<phase>process-test-resources</phase>
<goals>
<goal>copy-resources</goal>
</goals>
<configuration>
<outputDirectory>${project.build.testOutputDirectory}</outputDirectory>
<resources>
<resource>
<directory>${test-harness-launcher-resource}</directory>
<filtering>true</filtering>
</resource>
</resources>
</configuration>
</execution>
</executions>
</plugin>
{code}
Note that this defines an execution for the "copy-resources" goal whose parameter "resources" is *not* read-only, i.e. Max's configuration is valid. In contrast, the same parameter is read-only for the "resources" goal.
The corresponding output from Maven 3.x while building this POM:
{noformat}
ERROR: Cannot override read-only parameter: resources in goal: resources:resources
{noformat}
Note that this complains about the configuration for the "resources" goal. In other words, the configuration from the execution of "copy-resources" erroneously affects the execution of "resources".
> [regression] Configuration of custom plugin execution using default id pollutes configuration of default plugin executions introduced by packaging
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MNG-3927
> URL: http://jira.codehaus.org/browse/MNG-3927
> Project: Maven 2
> Issue Type: Bug
> Components: Plugins and Lifecycle
> Affects Versions: 3.0-alpha-1
> Reporter: Max Powers
> Assignee: Brian Fox
> Attachments: pom.xml
>
>
> Seems that maven is allowing pom writers to define new values for parameters that a plugin has marked as readOnly. I have attached a pom that overrides the resources parameter in the maven-resources-plugin. This is allowed in 2.0.9, but fails (as it should) in 3.x (see line 89)
> I would've expected to see this error (as i do in 3.x)
> [ERROR]
> ERROR: Cannot override read-only parameter: resources in goal: resources:resources
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3927) [regression] Configuration of custom
plugin execution using default id pollutes configuration of default plugin
executions introduced by packaging
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated MNG-3927:
------------------------------
Fix Version/s: 3.0-alpha-3
> [regression] Configuration of custom plugin execution using default id pollutes configuration of default plugin executions introduced by packaging
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MNG-3927
> URL: http://jira.codehaus.org/browse/MNG-3927
> Project: Maven 2
> Issue Type: Bug
> Components: Plugins and Lifecycle
> Affects Versions: 3.0-alpha-1
> Reporter: Max Powers
> Assignee: Brian Fox
> Fix For: 3.0-alpha-3
>
> Attachments: pom.xml
>
>
> Seems that maven is allowing pom writers to define new values for parameters that a plugin has marked as readOnly. I have attached a pom that overrides the resources parameter in the maven-resources-plugin. This is allowed in 2.0.9, but fails (as it should) in 3.x (see line 89)
> I would've expected to see this error (as i do in 3.x)
> [ERROR]
> ERROR: Cannot override read-only parameter: resources in goal: resources:resources
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3927) [regression] Configuration of custom
plugin execution using default id pollutes configuration of default plugin
executions introduced by packaging
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason van Zyl updated MNG-3927:
-------------------------------
Fix Version/s: (was: 3.0-alpha-3)
3.0-alpha-4
> [regression] Configuration of custom plugin execution using default id pollutes configuration of default plugin executions introduced by packaging
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MNG-3927
> URL: http://jira.codehaus.org/browse/MNG-3927
> Project: Maven 2
> Issue Type: Bug
> Components: Plugins and Lifecycle
> Affects Versions: 3.0-alpha-1
> Reporter: Max Powers
> Assignee: Brian Fox
> Fix For: 3.0-alpha-4
>
> Attachments: pom.xml
>
>
> Seems that maven is allowing pom writers to define new values for parameters that a plugin has marked as readOnly. I have attached a pom that overrides the resources parameter in the maven-resources-plugin. This is allowed in 2.0.9, but fails (as it should) in 3.x (see line 89)
> I would've expected to see this error (as i do in 3.x)
> [ERROR]
> ERROR: Cannot override read-only parameter: resources in goal: resources:resources
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira