You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/22 08:52:48 UTC
[GitHub] [flink] danny0405 opened a new pull request #12957: [FLINK-18500][table] Make the legacy planner exception more clear whe…
danny0405 opened a new pull request #12957:
URL: https://github.com/apache/flink/pull/12957
…n resolving computed columns types for schema
## What is the purpose of the change
The original stack trace throws an `UnsupportedOperationException` with null error message which is very confusing.
The new message suggest user to use the new planner.
## Brief change log
- Enhance the error message for computed columns of legacy planner
- Add test cases
## Verifying this change
Added UT.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe merged pull request #12957: [FLINK-18500][table] Make the legacy planner exception more clear whe…
Posted by GitBox <gi...@apache.org>.
godfreyhe merged pull request #12957:
URL: https://github.com/apache/flink/pull/12957
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12957: [FLINK-18500][table] Make the legacy planner exception more clear whe…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12957:
URL: https://github.com/apache/flink/pull/12957#issuecomment-662331897
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 027c4cb95690e75cb9a79e08bddcc67ee6d3a9c0 (Wed Jul 22 08:55:23 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-18500).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12957: [FLINK-18500][table] Make the legacy planner exception more clear whe…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12957:
URL: https://github.com/apache/flink/pull/12957#issuecomment-662341125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "027c4cb95690e75cb9a79e08bddcc67ee6d3a9c0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "027c4cb95690e75cb9a79e08bddcc67ee6d3a9c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 027c4cb95690e75cb9a79e08bddcc67ee6d3a9c0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on a change in pull request #12957: [FLINK-18500][table] Make the legacy planner exception more clear whe…
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on a change in pull request #12957:
URL: https://github.com/apache/flink/pull/12957#discussion_r458966544
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/ParserImpl.java
##########
@@ -83,6 +83,6 @@ public UnresolvedIdentifier parseIdentifier(String identifier) {
@Override
public ResolvedExpression parseSqlExpression(String sqlExpression, TableSchema inputSchema) {
- throw new UnsupportedOperationException();
+ throw new UnsupportedOperationException("Computed column is only supported by Blink planner.");
Review comment:
```suggestion
throw new UnsupportedOperationException("Computed columns is only supported by the Blink planner.");
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12957: [FLINK-18500][table] Make the legacy planner exception more clear whe…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12957:
URL: https://github.com/apache/flink/pull/12957#issuecomment-662341125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "027c4cb95690e75cb9a79e08bddcc67ee6d3a9c0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4721",
"triggerID" : "027c4cb95690e75cb9a79e08bddcc67ee6d3a9c0",
"triggerType" : "PUSH"
}, {
"hash" : "491363e1ed8d85b680cff74a8412fe4e878342b8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4746",
"triggerID" : "491363e1ed8d85b680cff74a8412fe4e878342b8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 027c4cb95690e75cb9a79e08bddcc67ee6d3a9c0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4721)
* 491363e1ed8d85b680cff74a8412fe4e878342b8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4746)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12957: [FLINK-18500][table] Make the legacy planner exception more clear whe…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12957:
URL: https://github.com/apache/flink/pull/12957#issuecomment-662341125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "027c4cb95690e75cb9a79e08bddcc67ee6d3a9c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4721",
"triggerID" : "027c4cb95690e75cb9a79e08bddcc67ee6d3a9c0",
"triggerType" : "PUSH"
}, {
"hash" : "491363e1ed8d85b680cff74a8412fe4e878342b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4746",
"triggerID" : "491363e1ed8d85b680cff74a8412fe4e878342b8",
"triggerType" : "PUSH"
}, {
"hash" : "6142f8bf5f9e4e146da83e7bea9977359fe7f60f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4752",
"triggerID" : "6142f8bf5f9e4e146da83e7bea9977359fe7f60f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6142f8bf5f9e4e146da83e7bea9977359fe7f60f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4752)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12957: [FLINK-18500][table] Make the legacy planner exception more clear whe…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12957:
URL: https://github.com/apache/flink/pull/12957#issuecomment-662341125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "027c4cb95690e75cb9a79e08bddcc67ee6d3a9c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4721",
"triggerID" : "027c4cb95690e75cb9a79e08bddcc67ee6d3a9c0",
"triggerType" : "PUSH"
}, {
"hash" : "491363e1ed8d85b680cff74a8412fe4e878342b8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4746",
"triggerID" : "491363e1ed8d85b680cff74a8412fe4e878342b8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 491363e1ed8d85b680cff74a8412fe4e878342b8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4746)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12957: [FLINK-18500][table] Make the legacy planner exception more clear whe…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12957:
URL: https://github.com/apache/flink/pull/12957#issuecomment-662341125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "027c4cb95690e75cb9a79e08bddcc67ee6d3a9c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4721",
"triggerID" : "027c4cb95690e75cb9a79e08bddcc67ee6d3a9c0",
"triggerType" : "PUSH"
}, {
"hash" : "491363e1ed8d85b680cff74a8412fe4e878342b8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4746",
"triggerID" : "491363e1ed8d85b680cff74a8412fe4e878342b8",
"triggerType" : "PUSH"
}, {
"hash" : "6142f8bf5f9e4e146da83e7bea9977359fe7f60f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6142f8bf5f9e4e146da83e7bea9977359fe7f60f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 491363e1ed8d85b680cff74a8412fe4e878342b8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4746)
* 6142f8bf5f9e4e146da83e7bea9977359fe7f60f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12957: [FLINK-18500][table] Make the legacy planner exception more clear whe…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12957:
URL: https://github.com/apache/flink/pull/12957#issuecomment-662341125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "027c4cb95690e75cb9a79e08bddcc67ee6d3a9c0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4721",
"triggerID" : "027c4cb95690e75cb9a79e08bddcc67ee6d3a9c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 027c4cb95690e75cb9a79e08bddcc67ee6d3a9c0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4721)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12957: [FLINK-18500][table] Make the legacy planner exception more clear whe…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12957:
URL: https://github.com/apache/flink/pull/12957#issuecomment-662341125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "027c4cb95690e75cb9a79e08bddcc67ee6d3a9c0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4721",
"triggerID" : "027c4cb95690e75cb9a79e08bddcc67ee6d3a9c0",
"triggerType" : "PUSH"
}, {
"hash" : "491363e1ed8d85b680cff74a8412fe4e878342b8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "491363e1ed8d85b680cff74a8412fe4e878342b8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 027c4cb95690e75cb9a79e08bddcc67ee6d3a9c0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4721)
* 491363e1ed8d85b680cff74a8412fe4e878342b8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12957: [FLINK-18500][table] Make the legacy planner exception more clear whe…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12957:
URL: https://github.com/apache/flink/pull/12957#issuecomment-662341125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "027c4cb95690e75cb9a79e08bddcc67ee6d3a9c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4721",
"triggerID" : "027c4cb95690e75cb9a79e08bddcc67ee6d3a9c0",
"triggerType" : "PUSH"
}, {
"hash" : "491363e1ed8d85b680cff74a8412fe4e878342b8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4746",
"triggerID" : "491363e1ed8d85b680cff74a8412fe4e878342b8",
"triggerType" : "PUSH"
}, {
"hash" : "6142f8bf5f9e4e146da83e7bea9977359fe7f60f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4752",
"triggerID" : "6142f8bf5f9e4e146da83e7bea9977359fe7f60f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 491363e1ed8d85b680cff74a8412fe4e878342b8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4746)
* 6142f8bf5f9e4e146da83e7bea9977359fe7f60f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4752)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12957: [FLINK-18500][table] Make the legacy planner exception more clear whe…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12957:
URL: https://github.com/apache/flink/pull/12957#issuecomment-662341125
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "027c4cb95690e75cb9a79e08bddcc67ee6d3a9c0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4721",
"triggerID" : "027c4cb95690e75cb9a79e08bddcc67ee6d3a9c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 027c4cb95690e75cb9a79e08bddcc67ee6d3a9c0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4721)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org