[jira] Commented: (GERONIMO-1189) [PATCH] Installer should be built from its own module in assemblies.

["David Jencks (JIRA)" <de...@geronimo.apache.org>]

    [ http://issues.apache.org/jira/browse/GERONIMO-1189?page=comments#action_12359393 ] 

David Jencks commented on GERONIMO-1189:
----------------------------------------

I applied most of the patch and added the 2 gifs. changes from patch:

-- there were errors in izpack-user-input.xml, missing = .  I fixed this
-- I changed the createForPack elements so they mostly applied to a page rather than a field.  In this way you don't see a blank page for stuff you decided not to install.
-- I did not apply the patches to the modules/assembly or modules/installer directories as I expect these to be removed tomorrow.

Questions...
Do you know if it is possible to set a variable as a result of selecting a  feature?  If so, we can handle the modifications of config.xml by defining a variable loadXXX for each configuration, and have load="${loadXXX}" in the section for each configuration in config.xml

I don't understand why you have check boxes on the last page for jetty/tomcat samples.  I think a new check box on the first page for each , dependent on selecting the web server, would be more appropriate.

I have some generic schema-finding code in the assembly plugin.   We should use it instead of the specific jelly code you have.  I still have to get the dtds extracted.

> [PATCH] Installer should be built from its own module in assemblies.
> --------------------------------------------------------------------
>
>          Key: GERONIMO-1189
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1189
>      Project: Geronimo
>         Type: Improvement
>   Components: installer
>     Versions: 1.0
>  Environment: Maven
>     Reporter: erik daughtrey
>  Attachments: geronimo-1189.patch, geronimo_banner_vert.gif, geronimo_med_vert.gif, installer.jar, jira1189_200512060118.patch
>
> It would be best to build using a Maven plugin. Otherwise, if impractical, use jelly. There seems to be an installer plugin for Maven 2, but not for the current build.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira