You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@forrest.apache.org by Sjur Moshagen <sj...@mac.com> on 2006/09/25 14:19:45 UTC

Dispatcher i18n update + three more issues

Hello all,

AS seen in JIRA, I have found a set of errors in Dispatcher and  
Forrest regarding i18n, and submitted patches for them. With those  
patches, Dispatcher should be ready to go re i18n - almost:-) There  
are still three more issues for which I can't submit a patch (I think):

1) one file is wrongly named in whiteboard/plugins/ 
o.a.f.plugin.internal.dispatcher/messages/

ContractsMessages_us.xml

should most likely be:

ContractsMessages_en.xml

2) There should probably be a default/fallback ContractsMessages.xml  
file, which should really be the file above (ie the English one, if  
one wants to have English as the fallback language, which I expect  
one does). Not having one will at least cause some noise in the log  
files, and might also generate errors

3) when doing a forrest seed, the translation files in whiteboard/ 
plugins/o.a.f.plugin.internal.dispatcher/messages/ should be included  
in the src/documentation/translations/ directory, with a proper note  
on them being useful only with the dispatcher. Without translation  
files in this location, the standard "messages" (Last published,  
Search, etc.) will not be translated.

Best regards,
Sjur

Re: Dispatcher i18n update + three more issues

Posted by Thorsten Scherler <th...@wyona.com>.

Sorry, sluggish/no internet connection and lots of work, prevent me to
be a bigger help.

some remarks:

On Tue, 2006-09-26 at 08:56 +0300, Sjur Moshagen wrote:
> Den 25. sep. 2006 kl. 17.17 skrev Gav....:
> 
> >> 3) when doing a forrest seed, the translation files in whiteboard/
> >> plugins/o.a.f.plugin.internal.dispatcher/messages/ should be included
> >> in the src/documentation/translations/ directory, with a proper note
> >> on them being useful only with the dispatcher. Without translation
> >> files in this location, the standard "messages" (Last published,
> >> Search, etc.) will not be translated.
> >
> > So what is the best way to do this, do you mean just moving the  
> > files into
> > That location permanently and removing them from their current  
> > location, or
> > Doing some xslt magic to create them there from the originals at  
> > build time?
> 
> I would imagine an ant task to copy the files as part of the forrest  
> seed task.

http://issues.apache.org/jira/browse/FOR-799 
and
http://issues.apache.org/jira/browse/FOR-809

This issue are about removing such ant tasks (the last issue is about
skin related copy task). Maybe we should take the opportunity and
refactor this targets. Something like forrest seed-dispatcher and
forrest seed-skins both based on the fresh site and then copying the
specific stuff from the plugins.

> 
> > Have you tested these locally with your patches you made ?
> 
> Yes, and I found that the Dispatcher translation files only work if  
> placed in the project location (but I didn't test this  
> systematically, so please repeat it with your setup)

It is a long time when I added the i18n support to the dispatcher and
since then hardly reviewed it. 
http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/internal.xmap?view=markup
<map:transformer name="i18n" 
        src="org.apache.cocoon.transformation.I18nTransformer">
        <catalogues default="contracts">
          <catalogue id="other" name="OtherMessages" location="{lm:project.translations}" />
          <catalogue id="contracts" name="ContractsMessages" 
            location="{lm:project.translations}" />
        </catalogues>
        <cache-at-startup>true</cache-at-startup>
      </map:transformer>

I reckon the problem is because {lm:project.translations} is not looking
into the fallback translation of the dispatcher. 

http://svn.apache.org/viewvc/forrest/trunk/main/webapp/locationmap-i18n.xml?view=markup

<match pattern="project.translations">
        <location src="{properties:translations}" />
    </match>

Did you try to change the properties:translations in your forrest.properties(.xml) to point to 
http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/messages/

That should work, but here you see that we need to harmonize the i18n stuff of all plugins.

> 
> > But I think a new Jira issue should be made to remember to do  
> > these, maybe
> > as a subtask as one of the others? Sub-tasks don't get used often  
> > enough
> > IMHO and think that maybe the three you just opened could have been  
> > all
> > sub-tasks of one jira issue. But this is a reflection on our  
> > current methods
> > as
> > A whole rather than how you created them - everyone else would have  
> > done the
> > Same I think. This is a good example of sub-tasking, each of those  
> > three
> > issues combined with the 3 new issues you identify above would not  
> > work
> > without the others also being completed.
> 
> I'll try to create one super-issue and add the existing (and new)  
> issues as sub-issues to that one.
> 
> > Great work on all this i18n stuff !! :)
> 
> Thanks:-)

Yeah, thanks very much Sjur. I will try to catch up with all your work
but ATM I am not able. Sorry and keep up the good work.

salu2
-- 
Thorsten Scherler
COO Spain
Wyona Inc.  -  Open Source Content Management  -  Apache Lenya
http://www.wyona.com                   http://lenya.apache.org
thorsten.scherler@wyona.com                thorsten@apache.org