You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ch...@apache.org on 2018/03/01 14:16:30 UTC

qpid-dispatch git commit: DISPATCH-918: allow blank strings as legal values in deprecationName processing

Repository: qpid-dispatch
Updated Branches:
  refs/heads/master 2a5633c43 -> 7a306e7a6


DISPATCH-918: allow blank strings as legal values in deprecationName processing


Project: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/commit/7a306e7a
Tree: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/tree/7a306e7a
Diff: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/diff/7a306e7a

Branch: refs/heads/master
Commit: 7a306e7a60667db62b1fbf28b0b8c1462d54af91
Parents: 2a5633c
Author: Chuck Rolke <cr...@redhat.com>
Authored: Wed Feb 28 16:45:09 2018 -0500
Committer: Chuck Rolke <cr...@redhat.com>
Committed: Thu Mar 1 09:15:30 2018 -0500

----------------------------------------------------------------------
 python/qpid_dispatch_internal/management/schema.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-dispatch/blob/7a306e7a/python/qpid_dispatch_internal/management/schema.py
----------------------------------------------------------------------
diff --git a/python/qpid_dispatch_internal/management/schema.py b/python/qpid_dispatch_internal/management/schema.py
index 01e0884..f2a487b 100644
--- a/python/qpid_dispatch_internal/management/schema.py
+++ b/python/qpid_dispatch_internal/management/schema.py
@@ -401,13 +401,13 @@ class EntityType(object):
                     deprecation_name = attr.deprecation_name
                     if deprecation_name:
                         value = attributes.get(deprecation_name)
-                        if value:
+                        if not value is None:
                             if logger_available:
                                 self.log(LOG_WARNING, "Attribute '%s' of entity '%s' has been deprecated."
                                                       " Use '%s' instead"%(deprecation_name, self.short_name, attr.name))
                             del attributes[deprecation_name]
 
-                    if not value:
+                    if value is None:
                         value = attr.missing_value()
                     if value is not None:
                         attributes[attr.name] = value
@@ -417,7 +417,7 @@ class EntityType(object):
                     deprecation_name = attr.deprecation_name
                     if deprecation_name:
                         value = attributes.get(deprecation_name)
-                        if value:
+                        if not value is None:
                             # Both name and deprecation name have values
                             # For example, both dir and direction of linkRoute have been specified, This is
                             # illegal. Just fail.


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org