You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "MonkeyCanCode (via GitHub)" <gi...@apache.org> on 2025/12/03 04:14:59 UTC

Re: [PR] [MCP] feat: Add realm support [polaris-tools]

MonkeyCanCode commented on code in PR #83:
URL: https://github.com/apache/polaris-tools/pull/83#discussion_r2583562151


##########
mcp-server/polaris_mcp/tools/catalog.py:
##########
@@ -106,6 +106,10 @@ def call(self, arguments: Any) -> ToolExecutionResult:
         copy_if_object(arguments.get("query"), delegate_args, "query")
         copy_if_object(arguments.get("headers"), delegate_args, "headers")
 
+        realm = arguments.get("realm")
+        if isinstance(realm, str) and realm.strip():
+            delegate_args["realm"] = realm

Review Comment:
   But realm is optional as if user didn't provide the realm, it will not be set via header. In this case, it will continue to work with Polairs server as it will just default to the first set realm in `polaris.realm-context.realms`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org