You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "isak-lindbeck (via GitHub)" <gi...@apache.org> on 2024/09/26 14:22:48 UTC
[PR] AVRO-4062: Allow leading underscores for names in idl [avro]
isak-lindbeck opened a new pull request, #3178:
URL: https://github.com/apache/avro/pull/3178
## What is the purpose of the change
This pull request adds support for names with leading underscore in idl. Fixing AVRO-4062
The specification is pretty clear that leading underscore is allowed.
## Verifying this change
This change added tests and can be verified as follows:
- *Added java test that parses an example avdl file with leading underscores*
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-4062: Allow leading underscores for names in idl [avro]
Posted by "opwvhk (via GitHub)" <gi...@apache.org>.
opwvhk commented on PR #3178:
URL: https://github.com/apache/avro/pull/3178#issuecomment-2411183557
Looks good, especially due to the added test case.
I also checked the spec on names, en this fixes a bug in allowed names. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-4062: Allow leading underscores for names in idl [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #3178:
URL: https://github.com/apache/avro/pull/3178#issuecomment-2411238778
> Since this fixes a bug introduced in 1.12 should I create another PR targeting the 1.12 branch?
I have cherry-picked it!
Thank you, @isak-lindbeck !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-4062: Allow leading underscores for names in idl [avro]
Posted by "opwvhk (via GitHub)" <gi...@apache.org>.
opwvhk merged PR #3178:
URL: https://github.com/apache/avro/pull/3178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-4062: Allow leading underscores for names in idl [avro]
Posted by "isak-lindbeck (via GitHub)" <gi...@apache.org>.
isak-lindbeck commented on PR #3178:
URL: https://github.com/apache/avro/pull/3178#issuecomment-2411034656
Thanks for the approve @martin-g, is there something more needed to do to get this PR merged?
Since this fixes a bug introduced in 1.12 should I create another PR targeting the 1.12 branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-4062: Allow leading underscores for names in idl [avro]
Posted by "opwvhk (via GitHub)" <gi...@apache.org>.
opwvhk commented on PR #3178:
URL: https://github.com/apache/avro/pull/3178#issuecomment-2919271117
It'll be in the next 1.12.x release. Though without a timeline, one is pending to fix a CVE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org