[jira] [Commented] (NIFI-3173) When creating a template Controller Services can end up being not properly scoped

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15741911#comment-15741911 ] 

ASF GitHub Bot commented on NIFI-3173:
--------------------------------------

GitHub user markap14 opened a pull request:

    https://github.com/apache/nifi/pull/1318

    NIFI-3173: When a template is created with multiple components in dif…

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    
    …ferent groups all referencing the same controller service, ensure that controller service is added to the template at a high enough level that all components needing hte service can access it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markap14/nifi NIFI-3173

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1318.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1318
    
----
commit 5b88bcea1149b8fa8a5741634a3bdaaa0657512b
Author: Mark Payne <ma...@hotmail.com>
Date:   2016-12-12T01:36:28Z

    NIFI-3173: When a template is created with multiple components in different groups all referencing the same controller service, ensure that controller service is added to the template at a high enough level that all components needing hte service can access it.

----


> When creating a template Controller Services can end up being not properly scoped
> ---------------------------------------------------------------------------------
>
>                 Key: NIFI-3173
>                 URL: https://issues.apache.org/jira/browse/NIFI-3173
>             Project: Apache NiFi
>          Issue Type: Bug
>            Reporter: Joseph Percivall
>             Fix For: 1.1.1
>
>
> Steps to reproduce:
> 1: From the root group create a Controller Service (ie. HttpContextMap)
> 2: Create two child process groups
> 3: In each child group create a processor that references the CS (ie. HandleHttpRequest and HandleHttpResponse)
> 4: Create a template of the two child PGs
> 5: Export the template
> 6: Import template into a clean instance
> 7: See the Controller service not scoped to the root level but instead scoped to one of the child PGs
> I believe the template creation is grabbing the first instance of the CS when it sees it and ignores the other references, instead of taking it at the highest level. I also believe this is related to NIFI-3129
> https://issues.apache.org/jira/browse/NIFI-3129



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)