You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by jtstorck <gi...@git.apache.org> on 2018/06/27 17:28:41 UTC
[GitHub] nifi pull request #2821: NIFI-5341 Enabled groovy tests in nifi-runtime
GitHub user jtstorck opened a pull request:
https://github.com/apache/nifi/pull/2821
NIFI-5341 Enabled groovy tests in nifi-runtime
Fixed tests in NiFiGroovyTest in the nifi-runtime module
Updated NiFi.createBootstrapClassLoader to log a warning if lib/bootstrap does not exist rather than throwing a FileNotFoundException, since it already catches MalformedUrlException if there's an issue adding one of the bootstrap JARs to the bootstrap classpath
Explicitly handling InvocationTargetException in NiFi.initializeProperties to unwrap the cause and rewrap as an IllegalArgumentException to propogate the real cause of the underlying exception thrown by NiFiPropertiesLoader
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jtstorck/nifi NIFI-5341
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2821.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2821
----
commit 174e213dc83cdbfa9e449c0b3b57f05673bc2167
Author: Jeff Storck <jt...@...>
Date: 2018-06-27T02:33:19Z
NIFI-5341 Enabled groovy tests in nifi-runtime
Fixed tests in NiFiGroovyTest in the nifi-runtime module
Updated NiFi.createBootstrapClassLoader to log a warning if lib/bootstrap does not exist rather than throwing a FileNotFoundException, since it already catches MalformedUrlException if there's an issue adding one of the bootstrap JARs to the bootstrap classpath
Explicitly handling InvocationTargetException in NiFi.initializeProperties to unwrap the cause and rewrap as an IllegalArgumentException to propogate the real cause of the underlying exception thrown by NiFiPropertiesLoader
----
---
[GitHub] nifi pull request #2821: NIFI-5341 Enabled groovy tests in nifi-runtime
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2821
---
[GitHub] nifi issue #2821: NIFI-5341 Enabled groovy tests in nifi-runtime
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2821
Ran `contrib-check` and all tests pass (ensured that `NiFiGroovyTest` runs with unit tests by default now). +1, merging.
---
[GitHub] nifi pull request #2821: NIFI-5341 Enabled groovy tests in nifi-runtime
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2821#discussion_r198676656
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-runtime/src/test/groovy/org/apache/nifi/NiFiGroovyTest.groovy ---
@@ -105,14 +97,13 @@ class NiFiGroovyTest extends GroovyTestCase {
NiFi.main(args)
// Assert
- assert TestAppender.events.last().getMessage() == "Failure to launch NiFi due to java.lang.IllegalArgumentException: The bootstrap process did not provide a valid key and there are protected properties present in the properties file"
+ assert TestAppender.events.last().getMessage() == "Failure to launch NiFi due to java.lang.IllegalArgumentException: There was an issue decrypting protected properties"
--- End diff --
This error message seems less helpful than the previous message. Is there a reason it is changed?
---
[GitHub] nifi issue #2821: NIFI-5341 Enabled groovy tests in nifi-runtime
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2821
Reviewing...
---
[GitHub] nifi issue #2821: NIFI-5341 Enabled groovy tests in nifi-runtime
Posted by jtstorck <gi...@git.apache.org>.
Github user jtstorck commented on the issue:
https://github.com/apache/nifi/pull/2821
@joewitt @alopresto This PR modifies code that was worked on by the two of you. I think there will be some discussion of the fixes, but I wanted to get a PR up ASAP to start the review process. Of interest, there's some exception handling changes in NiFi.java. NiFiGroovyTest needs to be able to invoke the main method, and since it's a unit test, lib/bootstrap isn't available. Creating a temp directory for the test didn't work out very well, based on varying PWDs between surefire and the IDE, so I thought this would be an acceptable approach.
---