You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/29 20:44:14 UTC

[GitHub] [incubator-superset] villebro commented on a change in pull request #9688: Make cache work again for annotations

villebro commented on a change in pull request #9688:
URL: https://github.com/apache/incubator-superset/pull/9688#discussion_r417599542



##########
File path: superset/connectors/sqla/models.py
##########
@@ -84,6 +84,7 @@ class AnnotationDatasource(BaseDatasource):
     """
 
     cache_timeout = 0
+    changed_on = None

Review comment:
       I would rather place this on `BaseDatasource` in `superset/connectors/base/models.py`, so as to make sure it propagates to all child classes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org