You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/12 11:30:10 UTC

[GitHub] [flink] wuchong commented on issue #10674: [FLINK-15220][Connector/Kafka][Table] Add startFromTimestamp in KafkaTableSource

wuchong commented on issue #10674: [FLINK-15220][Connector/Kafka][Table] Add startFromTimestamp in KafkaTableSource
URL: https://github.com/apache/flink/pull/10674#issuecomment-573405777
 
 
   I agree with @dawidwys , parsing from "2011-12-03 10:15:30" to a time second since epoch should involve time zone infromation. I'm fine to parse as `OffsetDateTime`.
   
   However, passing an `OffsetDateTime` is a little unfriendly to users. IMO, a better solution might be to use the time zone of `TableConfig`, but `TableConfig` is not exposed to `TableFactory` yet. So What about only support `connector.startup-timestamp-millis` in this version, and postpone to support `connector.startup-timestamp` when `TableFactory` can access the time zone information? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services