You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/03 11:08:44 UTC

[GitHub] [spark] zero323 commented on pull request #35367: [WIP][SPARK-37415][PYTHON][ML] Inline type hints for pyspark.ml.util

zero323 commented on pull request #35367:
URL: https://github.com/apache/spark/pull/35367#issuecomment-1028873667


   Thanks for the review @HyukjinKwon! I am still working on this one (there was an issue with some of the `Generic` positions, that caused MRO failures) and won't make it final until I have time to finalize `ml.wrapper` ‒  because we have crazy inheritance hierarchies with a lot of abstract things, making small changes tends to escalate all over the place (`ml.wrapper`, which is not big by itself, might require changes in stubs for all `ml` modules 😰, because of the abstract `_things` exposed to type checkers)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org