You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/02/06 10:10:55 UTC

[GitHub] [incubator-dolphinscheduler] qiaozhanwei opened a new pull request #1901: 1，LoggerServer and LoggerClientService add comment 2，code optimization

qiaozhanwei opened a new pull request #1901: 1，LoggerServer and LoggerClientService add comment 2，code optimization
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1901
 
 
   1，LoggerServer and LoggerClientService add comment
   2，code optimization

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1901: 1，LoggerServer and LoggerClientService add comment 2，code optimization

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #1901: 1，LoggerServer and LoggerClientService add comment 2，code optimization
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1901#issuecomment-582834832
 
 
   SonarCloud Quality Gate failed.
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1901&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1901&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/10.png' alt='7.3%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1901&metric=new_duplicated_lines_density&view=list) [7.3% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1901&metric=new_duplicated_lines_density&view=list)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1901: 1，LoggerServer and LoggerClientService add comment 2，code optimization

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #1901: 1，LoggerServer and LoggerClientService add comment 2，code optimization
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1901#issuecomment-582841477
 
 
   SonarCloud Quality Gate failed.
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1901&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1901&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1901&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1901&metric=new_duplicated_lines_density&view=list)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1901: 1，LoggerServer and LoggerClientService add comment 2，code optimization

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1901: 1，LoggerServer and LoggerClientService add comment 2，code optimization
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1901#issuecomment-582830190
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901?src=pr&el=h1) Report
   > Merging [#1901](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901?src=pr&el=desc) into [refactor-logger](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/992d0a69fe4e6c632a2a4d4dab9f21cb2a78bb7d?src=pr&el=desc) will **decrease** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901?src=pr&el=tree)
   
   ```diff
   @@                 Coverage Diff                 @@
   ##           refactor-logger    #1901      +/-   ##
   ===================================================
   - Coverage            19.62%   19.61%   -0.01%     
   ===================================================
     Files                  314      314              
     Lines                14510    14511       +1     
     Branches              2421     2421              
   ===================================================
     Hits                  2847     2847              
   - Misses               11337    11338       +1     
     Partials               326      326
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
   | [...phinscheduler/remote/utils/FastJsonSerializer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL0Zhc3RKc29uU2VyaWFsaXplci5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...he/dolphinscheduler/remote/codec/NettyDecoder.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvZGVjL05ldHR5RGVjb2Rlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...phinscheduler/remote/config/NettyClientConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbmZpZy9OZXR0eUNsaWVudENvbmZpZy5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...e/dolphinscheduler/remote/NettyRemotingServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdTZXJ2ZXIuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
   | [...he/dolphinscheduler/remote/utils/ChannelUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL0NoYW5uZWxVdGlscy5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...inscheduler/remote/handler/NettyClientHandler.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2hhbmRsZXIvTmV0dHlDbGllbnRIYW5kbGVyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
   | [...he/dolphinscheduler/remote/codec/NettyEncoder.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvZGVjL05ldHR5RW5jb2Rlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...pache/dolphinscheduler/service/log/LogPromise.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvbG9nL0xvZ1Byb21pc2UuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
   | [...inscheduler/remote/handler/NettyServerHandler.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2hhbmRsZXIvTmV0dHlTZXJ2ZXJIYW5kbGVyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
   | ... and [14 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901?src=pr&el=footer). Last update [992d0a6...9126929](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1901: 1，LoggerServer and LoggerClientService add comment 2，code optimization

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1901: 1，LoggerServer and LoggerClientService add comment 2，code optimization
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1901#issuecomment-582830190
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901?src=pr&el=h1) Report
   > Merging [#1901](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901?src=pr&el=desc) into [refactor-logger](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/992d0a69fe4e6c632a2a4d4dab9f21cb2a78bb7d?src=pr&el=desc) will **decrease** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901?src=pr&el=tree)
   
   ```diff
   @@                 Coverage Diff                 @@
   ##           refactor-logger    #1901      +/-   ##
   ===================================================
   - Coverage            19.62%   19.61%   -0.01%     
   ===================================================
     Files                  314      314              
     Lines                14510    14511       +1     
     Branches              2421     2421              
   ===================================================
     Hits                  2847     2847              
   - Misses               11337    11338       +1     
     Partials               326      326
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
   | [...phinscheduler/remote/utils/FastJsonSerializer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL0Zhc3RKc29uU2VyaWFsaXplci5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...he/dolphinscheduler/remote/codec/NettyDecoder.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvZGVjL05ldHR5RGVjb2Rlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...phinscheduler/remote/config/NettyClientConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbmZpZy9OZXR0eUNsaWVudENvbmZpZy5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...e/dolphinscheduler/remote/NettyRemotingServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdTZXJ2ZXIuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
   | [...he/dolphinscheduler/remote/utils/ChannelUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL0NoYW5uZWxVdGlscy5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...inscheduler/remote/handler/NettyClientHandler.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2hhbmRsZXIvTmV0dHlDbGllbnRIYW5kbGVyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
   | [...he/dolphinscheduler/remote/codec/NettyEncoder.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvZGVjL05ldHR5RW5jb2Rlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...pache/dolphinscheduler/service/log/LogPromise.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvbG9nL0xvZ1Byb21pc2UuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
   | [...inscheduler/remote/handler/NettyServerHandler.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2hhbmRsZXIvTmV0dHlTZXJ2ZXJIYW5kbGVyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
   | ... and [14 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901?src=pr&el=footer). Last update [992d0a6...24c111e](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1901: 1，LoggerServer and LoggerClientService add comment 2，code optimization

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1901: 1，LoggerServer and LoggerClientService add comment 2，code optimization
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1901#issuecomment-582830190
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901?src=pr&el=h1) Report
   > Merging [#1901](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901?src=pr&el=desc) into [refactor-logger](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/992d0a69fe4e6c632a2a4d4dab9f21cb2a78bb7d?src=pr&el=desc) will **decrease** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901?src=pr&el=tree)
   
   ```diff
   @@                 Coverage Diff                 @@
   ##           refactor-logger    #1901      +/-   ##
   ===================================================
   - Coverage            19.62%   19.61%   -0.01%     
   ===================================================
     Files                  314      314              
     Lines                14510    14511       +1     
     Branches              2421     2421              
   ===================================================
     Hits                  2847     2847              
   - Misses               11337    11338       +1     
     Partials               326      326
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
   | [...phinscheduler/remote/utils/FastJsonSerializer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL0Zhc3RKc29uU2VyaWFsaXplci5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...he/dolphinscheduler/remote/codec/NettyDecoder.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvZGVjL05ldHR5RGVjb2Rlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...phinscheduler/remote/config/NettyClientConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbmZpZy9OZXR0eUNsaWVudENvbmZpZy5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...e/dolphinscheduler/remote/NettyRemotingServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdTZXJ2ZXIuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
   | [...he/dolphinscheduler/remote/utils/ChannelUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL0NoYW5uZWxVdGlscy5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...inscheduler/remote/handler/NettyClientHandler.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2hhbmRsZXIvTmV0dHlDbGllbnRIYW5kbGVyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
   | [...he/dolphinscheduler/remote/codec/NettyEncoder.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvZGVjL05ldHR5RW5jb2Rlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...pache/dolphinscheduler/service/log/LogPromise.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvbG9nL0xvZ1Byb21pc2UuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
   | [...inscheduler/remote/handler/NettyServerHandler.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2hhbmRsZXIvTmV0dHlTZXJ2ZXJIYW5kbGVyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
   | ... and [14 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901?src=pr&el=footer). Last update [992d0a6...9126929](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1901?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on issue #1901: 1，LoggerServer and LoggerClientService add comment 2，code optimization

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on issue #1901: 1，LoggerServer and LoggerClientService add comment 2，code optimization
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1901#issuecomment-582834832
 
 
   SonarCloud Quality Gate failed.
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1901&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1901&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1901&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/10.png' alt='7.3%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1901&metric=new_duplicated_lines_density&view=list) [7.3% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1901&metric=new_duplicated_lines_density&view=list)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Technoboy- merged pull request #1901: 1，LoggerServer and LoggerClientService add comment 2，code optimization

Posted by GitBox <gi...@apache.org>.
Technoboy- merged pull request #1901: 1，LoggerServer and LoggerClientService add comment 2，code optimization
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1901
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services