You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/06/23 08:49:39 UTC
[GitHub] [zeppelin] cuspymd commented on a change in pull request #4126: [ZEPPELIN-5393] Polish rest, socket package of zeppelin-server
cuspymd commented on a change in pull request #4126:
URL: https://github.com/apache/zeppelin/pull/4126#discussion_r656891541
##########
File path: zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
##########
@@ -251,27 +250,27 @@ public void onOpen(NotebookSocket conn) {
@Override
public void onMessage(NotebookSocket conn, String msg) {
try {
- Message messagereceived = deserializeMessage(msg);
- if (messagereceived.op != OP.PING) {
- LOG.debug("RECEIVE: " + messagereceived.op +
- ", RECEIVE PRINCIPAL: " + messagereceived.principal +
- ", RECEIVE TICKET: " + messagereceived.ticket +
- ", RECEIVE ROLES: " + messagereceived.roles +
- ", RECEIVE DATA: " + messagereceived.data);
+ Message receivedMessage = deserializeMessage(msg);
+ if (receivedMessage.op != OP.PING) {
+ LOG.debug("RECEIVE: " + receivedMessage.op +
Review comment:
This PR is delayed too much, so I will fix it with a separate PR later.
##########
File path: zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
##########
@@ -251,27 +250,27 @@ public void onOpen(NotebookSocket conn) {
@Override
public void onMessage(NotebookSocket conn, String msg) {
try {
- Message messagereceived = deserializeMessage(msg);
- if (messagereceived.op != OP.PING) {
- LOG.debug("RECEIVE: " + messagereceived.op +
- ", RECEIVE PRINCIPAL: " + messagereceived.principal +
- ", RECEIVE TICKET: " + messagereceived.ticket +
- ", RECEIVE ROLES: " + messagereceived.roles +
- ", RECEIVE DATA: " + messagereceived.data);
+ Message receivedMessage = deserializeMessage(msg);
+ if (receivedMessage.op != OP.PING) {
+ LOG.debug("RECEIVE: " + receivedMessage.op +
+ ", RECEIVE PRINCIPAL: " + receivedMessage.principal +
+ ", RECEIVE TICKET: " + receivedMessage.ticket +
+ ", RECEIVE ROLES: " + receivedMessage.roles +
+ ", RECEIVE DATA: " + receivedMessage.data);
}
if (LOG.isTraceEnabled()) {
Review comment:
This PR is delayed too much, so I will fix it with a separate PR later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org