You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Rall <dl...@collab.net> on 2006/12/19 06:52:05 UTC
Re: svn commit: r22732 - branches/merge-tracking/subversion/libsvn_ra_dav
Kamesh, thanks for your attentiveness to the merge-tracking branch.
Please do take note that this commit was outside of the bounds of your
area; you are currently only approved for commits to the test area
without an explicit nod from another full committer. [1]
Thanks, Dan
[1] http://subversion.tigris.org/hacking.html#partial-commit-access
On Fri, 15 Dec 2006, kameshj@tigris.org wrote:
> Author: kameshj
> Date: Fri Dec 15 20:50:09 2006
> New Revision: 22732
>
> Log:
>
> fix the compile error introduced at r22716
>
> * subversion/libsvn_ra_dav/mergeinfo.c
> (svn_ra_dav__get_merge_info):
> ne_session members in svn_ra_dav__session_t are renamed at r22716.
> But the code didn't catch up with it.
>
> Patch by: Masaru Tsuchiyama <ts...@asahi-net.email.ne.jp>
>
>
> Modified:
> branches/merge-tracking/subversion/libsvn_ra_dav/mergeinfo.c
>
> Modified: branches/merge-tracking/subversion/libsvn_ra_dav/mergeinfo.c
> URL: http://svn.collab.net/viewvc/svn/branches/merge-tracking/subversion/libsvn_ra_dav/mergeinfo.c?pathrev=22732&r1=22731&r2=22732
> ==============================================================================
> --- branches/merge-tracking/subversion/libsvn_ra_dav/mergeinfo.c (original)
> +++ branches/merge-tracking/subversion/libsvn_ra_dav/mergeinfo.c Fri Dec 15 20:50:09 2006
> @@ -203,7 +203,7 @@
> mb.result = apr_hash_make(pool);
> mb.err = SVN_NO_ERROR;
>
> - err = svn_ra_dav__parsed_request(ras->sess,
> + err = svn_ra_dav__parsed_request(ras->ne_sess,
> "REPORT",
> ras->url->data,
> request_body->data,
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org
RE: svn commit: r22732 - branches/merge-tracking/subversion/libsvn_ra_dav
Posted by Kamesh Jayachandran <ka...@collab.net>.
Thanks David, Dlr.
Very big sorry for r22732.
Even though r22732 fixed the compile errors, it introduced the logical error that was causing make davautocheck tests to fail in merge-tracking branch.
Just identified the proper fix rerunning the testsuite to ensure that I did not miss anything this time.
With regards
Kamesh Jayachandran
-----Original Message-----
From: james82@gmail.com on behalf of David James
Sent: Wed 12/20/2006 12:03 AM
To: Kamesh Jayachandran
Cc: Daniel Rall; dev@subversion.tigris.org
Subject: Re: svn commit: r22732 - branches/merge-tracking/subversion/libsvn_ra_dav
On 12/19/06, David James <ja...@cs.toronto.edu> wrote:
> On 12/18/06, Kamesh Jayachandran <ka...@collab.net> wrote:
> > Sorry for stepping outside my area.
> >
> > If it was a feature or bug fix definitely would have waited for someone
> > to respond and would have expressed my [+/-]1 to those patches.
> >
> > As it was a compile failure and the patch was obvious enough, I felt
> > like committing.
>
> Kamesh, it's great to see that you are so dedicated to improving
> Subversion. Still, it's a good idea to follow the rules to the letter
> so that we can be sure all of your patches are appropriately reviewed.
> The "obvious fix" rule (which allows you to commit changes outside
> your area without review) only applies to documentation or code
> comments -- not actual code.
>
> Next time, post your patch to the dev@ list, and if it fixes an
> important compile error, I am sure it will be reviewed and committed
> quickly by a full committer.
>
> Thanks for your work!
P.S. (I've edited the log message for r22732 to indicate that your
commit is now approved by me.)
Re: svn commit: r22732 - branches/merge-tracking/subversion/libsvn_ra_dav
Posted by David James <ja...@cs.toronto.edu>.
On 12/19/06, David James <ja...@cs.toronto.edu> wrote:
> On 12/18/06, Kamesh Jayachandran <ka...@collab.net> wrote:
> > Sorry for stepping outside my area.
> >
> > If it was a feature or bug fix definitely would have waited for someone
> > to respond and would have expressed my [+/-]1 to those patches.
> >
> > As it was a compile failure and the patch was obvious enough, I felt
> > like committing.
>
> Kamesh, it's great to see that you are so dedicated to improving
> Subversion. Still, it's a good idea to follow the rules to the letter
> so that we can be sure all of your patches are appropriately reviewed.
> The "obvious fix" rule (which allows you to commit changes outside
> your area without review) only applies to documentation or code
> comments -- not actual code.
>
> Next time, post your patch to the dev@ list, and if it fixes an
> important compile error, I am sure it will be reviewed and committed
> quickly by a full committer.
>
> Thanks for your work!
P.S. (I've edited the log message for r22732 to indicate that your
commit is now approved by me.)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r22732 - branches/merge-tracking/subversion/libsvn_ra_dav
Posted by David James <ja...@cs.toronto.edu>.
On 12/18/06, Kamesh Jayachandran <ka...@collab.net> wrote:
> Sorry for stepping outside my area.
>
> If it was a feature or bug fix definitely would have waited for someone
> to respond and would have expressed my [+/-]1 to those patches.
>
> As it was a compile failure and the patch was obvious enough, I felt
> like committing.
Kamesh, it's great to see that you are so dedicated to improving
Subversion. Still, it's a good idea to follow the rules to the letter
so that we can be sure all of your patches are appropriately reviewed.
The "obvious fix" rule (which allows you to commit changes outside
your area without review) only applies to documentation or code
comments -- not actual code.
Next time, post your patch to the dev@ list, and if it fixes an
important compile error, I am sure it will be reviewed and committed
quickly by a full committer.
Thanks for your work!
David
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r22732 - branches/merge-tracking/subversion/libsvn_ra_dav
Posted by Kamesh Jayachandran <ka...@collab.net>.
Dan,
Sorry for stepping outside my area.
If it was a feature or bug fix definitely would have waited for someone
to respond and would have expressed my [+/-]1 to those patches.
As it was a compile failure and the patch was obvious enough, I felt
like committing.
With regards
Kamesh Jayachandran
Daniel Rall wrote:
> Kamesh, thanks for your attentiveness to the merge-tracking branch.
> Please do take note that this commit was outside of the bounds of your
> area; you are currently only approved for commits to the test area
> without an explicit nod from another full committer. [1]
>
> Thanks, Dan
>
> [1] http://subversion.tigris.org/hacking.html#partial-commit-access
>
>
> On Fri, 15 Dec 2006, kameshj@tigris.org wrote:
>
>
>> Author: kameshj
>> Date: Fri Dec 15 20:50:09 2006
>> New Revision: 22732
>>
>> Log:
>>
>> fix the compile error introduced at r22716
>>
>> * subversion/libsvn_ra_dav/mergeinfo.c
>> (svn_ra_dav__get_merge_info):
>> ne_session members in svn_ra_dav__session_t are renamed at r22716.
>> But the code didn't catch up with it.
>>
>> Patch by: Masaru Tsuchiyama <ts...@asahi-net.email.ne.jp>
>>
>>
>> Modified:
>> branches/merge-tracking/subversion/libsvn_ra_dav/mergeinfo.c
>>
>> Modified: branches/merge-tracking/subversion/libsvn_ra_dav/mergeinfo.c
>> URL: http://svn.collab.net/viewvc/svn/branches/merge-tracking/subversion/libsvn_ra_dav/mergeinfo.c?pathrev=22732&r1=22731&r2=22732
>> ==============================================================================
>> --- branches/merge-tracking/subversion/libsvn_ra_dav/mergeinfo.c (original)
>> +++ branches/merge-tracking/subversion/libsvn_ra_dav/mergeinfo.c Fri Dec 15 20:50:09 2006
>> @@ -203,7 +203,7 @@
>> mb.result = apr_hash_make(pool);
>> mb.err = SVN_NO_ERROR;
>>
>> - err = svn_ra_dav__parsed_request(ras->sess,
>> + err = svn_ra_dav__parsed_request(ras->ne_sess,
>> "REPORT",
>> ras->url->data,
>> request_body->data,
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
>> For additional commands, e-mail: svn-help@subversion.tigris.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org