You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/07/25 09:57:39 UTC

[GitHub] flink pull request #4393: [FLINK-7254] [java8] Properly activate checkstyle ...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/4393

    [FLINK-7254] [java8] Properly activate checkstyle for flink-java8

    This PR modifies the java8 pom to not disable checkstyle. A few changes had to be made to make the module checkstyle compliant.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 7254

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4393.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4393
    
----
commit 2c0d1a32179fd7dfa6efbac6b55ae334f30fa74c
Author: zentol <ch...@apache.org>
Date:   2017-07-24T12:14:19Z

    [FLINK-7254] [java8] Properly activate checkstyle for flink-java8

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4393: [FLINK-7254] [java8] Properly activate checkstyle for fli...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4393
  
    merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4393: [FLINK-7254] [java8] Properly activate checkstyle for fli...

Posted by greghogan <gi...@git.apache.org>.

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/4393
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4393: [FLINK-7254] [java8] Properly activate checkstyle ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4393


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4393: [FLINK-7254] [java8] Properly activate checkstyle for fli...

Posted by dawidwys <gi...@git.apache.org>.

Github user dawidwys commented on the issue:

    https://github.com/apache/flink/pull/4393
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---