You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Erwan de FERRIERES (JIRA)" <ji...@apache.org> on 2009/11/04 18:11:32 UTC
[jira] Created: (OFBIZ-3153) Relation title not needed on Facility
entity
Relation title not needed on Facility entity
--------------------------------------------
Key: OFBIZ-3153
URL: https://issues.apache.org/jira/browse/OFBIZ-3153
Project: OFBiz
Issue Type: Bug
Components: product
Affects Versions: SVN trunk
Reporter: Erwan de FERRIERES
Fix For: SVN trunk
Attachments: OFBIZ-3153.diff
the title Geo Point is not needed on the entity Facility as there is only one relation to GeoPoint
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3153) Relation title not needed on
Facility entity
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773651#action_12773651 ]
Jacques Le Roux commented on OFBIZ-3153:
----------------------------------------
Even ModelEntity.getRelation() ?
> Relation title not needed on Facility entity
> --------------------------------------------
>
> Key: OFBIZ-3153
> URL: https://issues.apache.org/jira/browse/OFBIZ-3153
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3153.diff
>
>
> the title Geo Point is not needed on the entity Facility as there is only one relation to GeoPoint
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3153) Relation title not needed on
Facility entity
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774039#action_12774039 ]
Jacques Le Roux commented on OFBIZ-3153:
----------------------------------------
Thanks Adrian,
Convinced, changed to many in trunk at r833136, R9.04 r833140
> Relation title not needed on Facility entity
> --------------------------------------------
>
> Key: OFBIZ-3153
> URL: https://issues.apache.org/jira/browse/OFBIZ-3153
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Jacques Le Roux
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-3153.diff
>
>
> the title Geo Point is not needed on the entity Facility as there is only one relation to GeoPoint
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3153) Relation title not needed on Facility
entity
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwan de FERRIERES updated OFBIZ-3153:
--------------------------------------
Attachment: OFBIZ-3153.diff
> Relation title not needed on Facility entity
> --------------------------------------------
>
> Key: OFBIZ-3153
> URL: https://issues.apache.org/jira/browse/OFBIZ-3153
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3153.diff
>
>
> the title Geo Point is not needed on the entity Facility as there is only one relation to GeoPoint
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3153) Relation title not needed on
Facility entity
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774031#action_12774031 ]
Adrian Crum commented on OFBIZ-3153:
------------------------------------
Facilities are not in heaps, but a multi-story building could be considered a stacked facility. The third floor conference room facility would have an elevation. An employee wearing an RFID badge could be located in that conference room.
> Relation title not needed on Facility entity
> --------------------------------------------
>
> Key: OFBIZ-3153
> URL: https://issues.apache.org/jira/browse/OFBIZ-3153
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Jacques Le Roux
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-3153.diff
>
>
> the title Geo Point is not needed on the entity Facility as there is only one relation to GeoPoint
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3153) Relation title not needed on
Facility entity
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773583#action_12773583 ]
Jacques Le Roux commented on OFBIZ-3153:
----------------------------------------
Hi Erwan,
I'm not sure it is worth it, because as we are removing something we need to take care of what is currently in existence : http://docs.ofbiz.org/display/OFBTECH/Revisions+Requiring+Data+Migration
> Relation title not needed on Facility entity
> --------------------------------------------
>
> Key: OFBIZ-3153
> URL: https://issues.apache.org/jira/browse/OFBIZ-3153
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3153.diff
>
>
> the title Geo Point is not needed on the entity Facility as there is only one relation to GeoPoint
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3153) Relation title not needed on
Facility entity
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773901#action_12773901 ]
Jacques Le Roux commented on OFBIZ-3153:
----------------------------------------
Hi Erwan,
These are good questions
>why naming a relation with the name of the related entity ?
I just picked that name by analogy with what is just above : Country/countryGeoId, ... PostalCode/postalCodeGeoId. Is there a problem with that ?
>why naming a relation with a space in it ?
Yes good question, I guess it should not have one, not sure it's a problem though... Did you try ? BTW we have the same for Facility entity.
And, usually, naming a relation is used when there is more than one relation to another entity, like from/to or parent/child
OK, it's a bit convoluted and scifi for now, but consider that our geopoints have an elevation attribute. So a postal address may have many geopoints (at least in the future...)
> Relation title not needed on Facility entity
> --------------------------------------------
>
> Key: OFBIZ-3153
> URL: https://issues.apache.org/jira/browse/OFBIZ-3153
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3153.diff
>
>
> the title Geo Point is not needed on the entity Facility as there is only one relation to GeoPoint
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3153) Relation title not needed on
Facility entity
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773870#action_12773870 ]
Erwan de FERRIERES commented on OFBIZ-3153:
-------------------------------------------
Hi Jacques,
even in modelEntity.getRelation...
why naming a relation with the name of the related entity ?
why naming a relation with a space in it ?
And, usually, naming a relation is used when there is more than one relation to another entity, like from/to or parent/child, so when making a getRelatedOne we can have the data requested.
> Relation title not needed on Facility entity
> --------------------------------------------
>
> Key: OFBIZ-3153
> URL: https://issues.apache.org/jira/browse/OFBIZ-3153
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3153.diff
>
>
> the title Geo Point is not needed on the entity Facility as there is only one relation to GeoPoint
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3153) Relation title not needed on
Facility entity
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774226#action_12774226 ]
Erwan de FERRIERES commented on OFBIZ-3153:
-------------------------------------------
Thanks Jacques for commiting !
> Relation title not needed on Facility entity
> --------------------------------------------
>
> Key: OFBIZ-3153
> URL: https://issues.apache.org/jira/browse/OFBIZ-3153
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Jacques Le Roux
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-3153.diff
>
>
> the title Geo Point is not needed on the entity Facility as there is only one relation to GeoPoint
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3153) Relation title not needed on
Facility entity
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774158#action_12774158 ]
Jacques Le Roux commented on OFBIZ-3153:
----------------------------------------
Hi Erwan,
I finally followed your advice both in trunk (r833264) and R9.04 (r833258).
I need to redesign in trunk because not only we may have several flats or offices at respectively the same postal address or facility; but we need also to differentiate them because the triplet (lat., long., elevation) may be the same for several flats, offices. Except if we consider that we have a sufficient accuracy for these values which is not quite true nowadays.
> Relation title not needed on Facility entity
> --------------------------------------------
>
> Key: OFBIZ-3153
> URL: https://issues.apache.org/jira/browse/OFBIZ-3153
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Jacques Le Roux
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-3153.diff
>
>
> the title Geo Point is not needed on the entity Facility as there is only one relation to GeoPoint
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3153) Relation title not needed on
Facility entity
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773636#action_12773636 ]
Scott Gray commented on OFBIZ-3153:
-----------------------------------
Changing the title shouldn't have any effect on the database hence no migration is required
> Relation title not needed on Facility entity
> --------------------------------------------
>
> Key: OFBIZ-3153
> URL: https://issues.apache.org/jira/browse/OFBIZ-3153
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3153.diff
>
>
> the title Geo Point is not needed on the entity Facility as there is only one relation to GeoPoint
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3153) Relation title not needed on
Facility entity
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773930#action_12773930 ]
Erwan de FERRIERES commented on OFBIZ-3153:
-------------------------------------------
We agree that there is no problem naming the relation with a space in it, as we are using strings, this should not cause any arm.
What I would like to say is when making a getRelated action, in java or minilang, we have to write getRelated("Geo pointGeoPoint"), and this could be confusing for any new user, or when reading code.
If a postal address has many geopoints, then each one should be characterized with a different relation, and not named Geo point for each. For example, we vould have EastGeoPoint, WestGeoPoint, and this as many as we want to have, isn't it ?
> Relation title not needed on Facility entity
> --------------------------------------------
>
> Key: OFBIZ-3153
> URL: https://issues.apache.org/jira/browse/OFBIZ-3153
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3153.diff
>
>
> the title Geo Point is not needed on the entity Facility as there is only one relation to GeoPoint
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3153) Relation title not needed on Facility
entity
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-3153.
----------------------------------
Resolution: Fixed
Fix Version/s: Release Branch 9.04
Assignee: Jacques Le Roux
Erwan,
I agree that the space in the name is confusing. I will use Point instead. Also your remark made me think that for PostalAddress it's actually not a one relationship but many because of the elevation field. In the case of Facility it's not the same since I don't expect Facilities to ever be in heaps ;)
I put the changes in trunk at r833113, R9.04 at r833114
Thanks for the refreshing discussion.
> Relation title not needed on Facility entity
> --------------------------------------------
>
> Key: OFBIZ-3153
> URL: https://issues.apache.org/jira/browse/OFBIZ-3153
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Reporter: Erwan de FERRIERES
> Assignee: Jacques Le Roux
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-3153.diff
>
>
> the title Geo Point is not needed on the entity Facility as there is only one relation to GeoPoint
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.