You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/07 04:11:05 UTC
[GitHub] [doris] BiteTheDDDDt opened a new pull request, #14872: [Pipeline](sink) support olap table sink operator
BiteTheDDDDt opened a new pull request, #14872:
URL: https://github.com/apache/doris/pull/14872
# Proposed changes
<img width="541" alt="图片" src="https://user-images.githubusercontent.com/7939630/206086221-24e0f5ea-a136-4b9e-9fa3-45a8a4b54c42.png">
<img width="896" alt="图片" src="https://user-images.githubusercontent.com/7939630/206086245-6e7f06a3-3e7c-4b52-bd9f-59763ca0957c.png">
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #14872: [Pipeline](sink) support olap table sink operator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #14872:
URL: https://github.com/apache/doris/pull/14872#discussion_r1041738302
##########
be/src/pipeline/exec/operator.h:
##########
@@ -294,38 +294,38 @@
return Status::OK();
}
- virtual Status open(RuntimeState* state) override {
+ Status open(RuntimeState* state) override {
SCOPED_TIMER(_runtime_profile->total_time_counter());
RETURN_IF_ERROR(_node->alloc_resource(state));
return Status::OK();
}
- virtual Status sink(RuntimeState* state, vectorized::Block* in_block,
- SourceState source_state) override {
+ Status sink(RuntimeState* state, vectorized::Block* in_block,
+ SourceState source_state) override {
SCOPED_TIMER(_runtime_profile->total_time_counter());
return _node->sink(state, in_block, source_state == SourceState::FINISHED);
}
- virtual Status close(RuntimeState* state) override {
+ Status close(RuntimeState* state) override {
_fresh_exec_timer(_node);
if (!_node->decrease_ref()) {
_node->release_resource(state);
}
return Status::OK();
}
- virtual Status get_block(RuntimeState* state, vectorized::Block* block,
- SourceState& source_state) override {
+ Status get_block(RuntimeState* state, vectorized::Block* block,
+ SourceState& source_state) override {
SCOPED_TIMER(_runtime_profile->total_time_counter());
bool eos = false;
RETURN_IF_ERROR(_node->pull(state, block, &eos));
source_state = eos ? SourceState::FINISHED : SourceState::DEPEND_ON_SOURCE;
return Status::OK();
}
- virtual Status finalize(RuntimeState* state) override { return Status::OK(); }
+ Status finalize(RuntimeState* state) override { return Status::OK(); }
Review Comment:
warning: parameter 'state' is unused [misc-unused-parameters]
```suggestion
/*state*/
```
##########
be/src/pipeline/exec/operator.h:
##########
@@ -258,12 +258,12 @@ class DataSinkOperator : public OperatorBase {
return _sink->send(state, in_block, source_state == SourceState::FINISHED);
}
- virtual Status close(RuntimeState* state) override {
+ Status close(RuntimeState* state) override {
_fresh_exec_timer(_sink);
return _sink->close(state, Status::OK());
}
- virtual Status finalize(RuntimeState* state) override { return Status::OK(); }
+ Status finalize(RuntimeState* state) override { return Status::OK(); }
Review Comment:
warning: parameter 'state' is unused [misc-unused-parameters]
```suggestion
/*state*/
```
##########
be/src/pipeline/exec/operator.h:
##########
@@ -283,9 +283,9 @@
Operator(OperatorBuilderBase* builder, ExecNode* node)
: OperatorBase(builder), _node(reinterpret_cast<NodeType*>(node)) {};
- virtual ~Operator() = default;
+ ~Operator() override = default;
- virtual Status prepare(RuntimeState* state) override {
+ Status prepare(RuntimeState* state) override {
Review Comment:
warning: parameter 'state' is unused [misc-unused-parameters]
```suggestion
fault; /*state*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #14872: [Pipeline](sink) support olap table sink operator
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #14872:
URL: https://github.com/apache/doris/pull/14872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14872: [Pipeline](sink) support olap table sink operator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14872:
URL: https://github.com/apache/doris/pull/14872#issuecomment-1340510185
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14872: [Pipeline](sink) support olap table sink operator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14872:
URL: https://github.com/apache/doris/pull/14872#issuecomment-1340510139
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14872: [Pipeline](sink) support olap table sink operator
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14872:
URL: https://github.com/apache/doris/pull/14872#issuecomment-1340395997
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.08 seconds
load time: 428 seconds
storage size: 17123356357 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221207053226_clickbench_pr_59123.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org