You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/05 12:48:31 UTC

[GitHub] [airflow] josh-fell commented on pull request #19419: Handle more patterns in `restrict-start_date` pre-commit hook

josh-fell commented on pull request #19419:
URL: https://github.com/apache/airflow/pull/19419#issuecomment-961869100


   >The old Chinese proverb says: "If you have a problem, introduce regexp - you will have two problems". This regexp will be impossible to reason about, fix and improve by anyone who will add a different pattern in the future.
   
   Another daily, wisdom nugget presented by @potiuk.
   
   I like the ast tree idea. In #19237 we briefly discussed adding a pre-commit hook to validate `catchup=False` was set in example DAGs. Seems like this ast approach would yield a hook that kills two birds with one stone too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org