You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/02/14 18:28:22 UTC
[GitHub] [activemq-artemis] franz1981 opened a new pull request #2984:
ARTEMIS-2617 Fixing KMPNeedle::searchInto API and specializing it
franz1981 opened a new pull request #2984: ARTEMIS-2617 Fixing KMPNeedle::searchInto API and specializing it
URL: https://github.com/apache/activemq-artemis/pull/2984
KMPNeedle::searchInto has been specialized and copied
to handle ReadableBuffer in order to save polymorphic
calls on it that would make it slower on hot paths.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #2984: ARTEMIS-2617
Fixing KMPNeedle::searchInto API and specializing it
Posted by GitBox <gi...@apache.org>.
franz1981 commented on issue #2984: ARTEMIS-2617 Fixing KMPNeedle::searchInto API and specializing it
URL: https://github.com/apache/activemq-artemis/pull/2984#issuecomment-586412613
I still need to write some tests on it: I've benchmarked the version with a polymorphic lamda getting mixed feeling on it and I've chosen to safely specialize it to get the best possible performance for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] asfgit closed pull request #2984: ARTEMIS-2617
Fixing KMPNeedle::searchInto API and specializing it
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2984: ARTEMIS-2617 Fixing KMPNeedle::searchInto API and specializing it
URL: https://github.com/apache/activemq-artemis/pull/2984
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2984:
ARTEMIS-2617 Fixing KMPNeedle::searchInto API and specializing it
Posted by GitBox <gi...@apache.org>.
franz1981 edited a comment on issue #2984: ARTEMIS-2617 Fixing KMPNeedle::searchInto API and specializing it
URL: https://github.com/apache/activemq-artemis/pull/2984#issuecomment-586412613
I still need to write some tests on it: I've benchmarked the version with a polymorphic lambda getting mixed feeling on it and I've chosen to safely specialize it to get the best possible performance for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services