You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by lindzh <gi...@git.apache.org> on 2017/07/03 00:35:03 UTC

[GitHub] incubator-rocketmq pull request #126: [ROCKETMQ-231] fix pull consumer pull ...

Github user lindzh commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/126#discussion_r125196481
  
    --- Diff: store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java ---
    @@ -1110,7 +1110,7 @@ private boolean isTheBatchFull(int sizePy, int maxMsgNums, int bufferTotal, int
                 return false;
             }
     
    -        if ((messageTotal + 1) >= maxMsgNums) {
    --- End diff --
    
    Yet,That a good idea to make code clean


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---