You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by al...@apache.org on 2016/12/27 09:14:13 UTC

cordova-plugin-contacts git commit: CB-12300: fix tests failure when running it using jasmine-node

Repository: cordova-plugin-contacts
Updated Branches:
  refs/heads/master 58d4612f9 -> 88192bf17


CB-12300: fix tests failure when running it using jasmine-node


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/commit/88192bf1
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/tree/88192bf1
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/diff/88192bf1

Branch: refs/heads/master
Commit: 88192bf17fe0dc790ae705a7a4f14d016b48f254
Parents: 58d4612
Author: Meir Rotstein <me...@rotstein.co.il>
Authored: Tue Dec 27 11:06:39 2016 +0200
Committer: Meir Rotstein <me...@rotstein.co.il>
Committed: Tue Dec 27 11:06:39 2016 +0200

----------------------------------------------------------------------
 tests/tests.js | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/blob/88192bf1/tests/tests.js
----------------------------------------------------------------------
diff --git a/tests/tests.js b/tests/tests.js
index e81b6f0..3a7f91c 100644
--- a/tests/tests.js
+++ b/tests/tests.js
@@ -692,7 +692,9 @@ exports.defineAutoTests = function() {
                 contact.name = new ContactName();
                 contact.name.familyName = contactName;
                 contact.note = "DeleteMe";
-                saveAndFindBy(contact, ["displayName", "name"], contactName, done, this);
+                saveAndFindBy(contact, ["displayName", "name"], contactName, function() {
+                    done();
+                }, this);
             }, MEDIUM_TIMEOUT);
 
             it("contacts.spec.26 Creating, saving, finding a contact should work, removing it should work", function(done) {
@@ -757,7 +759,9 @@ exports.defineAutoTests = function() {
                 contact.note = "DeleteMe";
                 contact.name = new ContactName();
                 contact.name.familyName = contactName;
-                saveAndFindBy(contact, ["displayName", "name"], contactName, done, this);
+                saveAndFindBy(contact, ["displayName", "name"], contactName, function() {
+                    done();
+                }, this);
             }, MEDIUM_TIMEOUT);
 
             it("contacts.spec.29 should find a contact without a name", function (done) {
@@ -771,7 +775,9 @@ exports.defineAutoTests = function() {
                 phoneNumbers[0] = new ContactField('work', '555-555-1234', true);
                 contact.phoneNumbers = phoneNumbers;
 
-                saveAndFindBy(contact, ["phoneNumbers"], "555-555-1234", done, this);
+                saveAndFindBy(contact, ["phoneNumbers"], "555-555-1234", function() {
+                    done();
+                }, this);
 
             }, MEDIUM_TIMEOUT);
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org