You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org> on 2012/06/29 15:21:44 UTC
[jira] [Commented] (TOMAHAWK-1630) Render conditional comments for
IE at the html tag
[ https://issues.apache.org/jira/browse/TOMAHAWK-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403888#comment-13403888 ]
Leonardo Uribe commented on TOMAHAWK-1630:
------------------------------------------
I think it is a very useful feature. I would like to find a better name for renderConditionalCommentsAndStyleClasses . Maybe includeBrowserSelectors ? It could be more meaningful.
> Render conditional comments for IE at the html tag
> --------------------------------------------------
>
> Key: TOMAHAWK-1630
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1630
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Affects Versions: 1.1.11
> Environment: MyFaces 2.1.6, Tomahawk20 1.1.11
> Reporter: dennis hoersch
> Attachments: Document.java, DocumentRenderer.java, patch_Document.txt, patch_DocumentRenderer.txt
>
>
> Hi,
> in our old (pre-JSF2) product version we use some IE conditional comments to insert IE specific stylesheets:
> <h:outputText
> value="<!--[if IE 9]><link rel="stylesheet" type="text/css" href="/path/to/someIE9.css"/><![endif]-->"
> escape="false" />
> But now I want to use <h:outputStylesheet />. (So that the stylesheets are registered at the view root.)
> My researches in the Internet gave me a solution used by other frameworks: surround the HTML root tag with conditional comments an give them IE version specific classes:
> <!--[if lt IE 7 ]><html xmlns="http://www.w3.org/1999/xhtml" lang="de" class="ie ie6"><![endif]-->
> <!--[if IE 7 ]><html xmlns="http://www.w3.org/1999/xhtml" lang="de" class="ie ie7"><![endif]-->
> <!--[if IE 8 ]><html xmlns="http://www.w3.org/1999/xhtml" lang="de" class="ie ie8"><![endif]-->
> <!--[if IE 9 ]><html xmlns="http://www.w3.org/1999/xhtml" lang="de" class="ie ie9"><![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--><html xmlns="http://www.w3.org/1999/xhtml" lang="de"><!--<![endif]-->
> so we can have style definitions like:
> .ie8 .someOtherClass {...}
> I attached a patch of the Document to support an attribute which causes the DocumentRenderer to render these conditional comments on the HTML root tag.
> May it be reasonable to Tomahawk to support this?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira