[GitHub] [spark] beliefer commented on pull request #35269: [SPARK-28516][SQL] Data Type Formatting Functions: `to_char`

[GitBox <gi...@apache.org>]

beliefer commented on pull request #35269:
URL: https://github.com/apache/spark/pull/35269#issuecomment-1067755703


   > @beliefer "So, this PR follows the implement of to_char in Oracle that give a strict parameter verification.
   > So, this PR follows the implement of to_char in Phoenix that uses DecimalFormat."
   > Are they the same?
   > Can you speak to error conditions, maybe some examples
   
   For example:
   'S' or '-' must be the first or last char in the number format
   At most one 'S' or '-' is allowed in the number format
   '$' must be the first or last char in the number format
   At most one '$' is allowed in the number format
   Variable group size in the number format
   At most one 'D' or '.' is allowed in the number format
   Format expression must be foldable
   Number format cannot be empty
   Illegal number format for DecimalFormat.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org