You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/08/14 13:20:45 UTC

[GitHub] pnowojski edited a comment on issue #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream

pnowojski edited a comment on issue #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream
URL: https://github.com/apache/flink/pull/6367#issuecomment-412868964
 
 
   Yes exactly. More precisely as I wrote in one of the previous comments, this `TaskOutputWriter` (`TaskStandardOutputWriter`?) would deduplicate logic from those methods:
   
   - open
   - writeRecord/invoke
   - toString
   - close (those probably should be dropped because of NPE.)
   
   Because their logic is identical between `PrintSinkFunction` and `PrintingOutputFormat` while their implementation is already inconsistent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services