[GitHub] [iceberg] bryanck commented on a diff in pull request #7262: AWS: abort S3 input stream on close if not EOS

["bryanck (via GitHub)" <gi...@apache.org>]

bryanck commented on code in PR #7262:
URL: https://github.com/apache/iceberg/pull/7262#discussion_r1155343075


##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3OutputStream.java:
##########
@@ -212,9 +212,7 @@ public void write(byte[] b, int off, int len) throws IOException {
   }
 
   private void newStream() throws IOException {
-    if (stream != null) {
-      stream.close();
-    }
+    closeStream();

Review Comment:
   This will always throw on an aborted stream on a checksum check failure, so it could be very noisy.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org