You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/10/28 16:29:54 UTC

[GitHub] [arrow-datafusion] alamb commented on issue #1162: Add additional algebraic simplifications

alamb commented on issue #1162:
URL: https://github.com/apache/arrow-datafusion/issues/1162#issuecomment-954008545


   @matthewmturner  I think you might find some interesting work here if you wanted
   
   Specifically the idea would be to add the simplification rules in the description of this PR  to the logic in `Simplify` here:
   
   https://github.com/apache/arrow-datafusion/blob/2c8e65bcca9fe41ad80116d99ad974c86cb59654/datafusion/src/optimizer/constant_folding.rs#L140-L230
   
   And then write tests following the pattern here: https://github.com/apache/arrow-datafusion/blob/2c8e65bcca9fe41ad80116d99ad974c86cb59654/datafusion/src/optimizer/constant_folding.rs#L267-L279


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org