You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/09/06 05:10:39 UTC

[GitHub] [netbeans] jlahoda opened a new pull request, #4586: Fixing error recovery for (current) record patterns.

jlahoda opened a new pull request, #4586:
URL: https://github.com/apache/netbeans/pull/4586

   `tree.type` may be `null`, and `error2Object` will return `null` for `null` input, and the current code will reset the `sym.type` to `null` as well, which is obviously problematic/wrong.
   
   
   ---
   **^Add meaningful description above**
   
   By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
   
    - are all your own work, and you have the right to contribute them.
    - are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
   
   Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
   
   If you're a first time contributor, see the Contributing guidelines for more information.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on pull request #4586: Fixing error recovery for (current) record patterns.

Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4586:
URL: https://github.com/apache/netbeans/pull/4586#issuecomment-1269560063

   > well I see it green, I merged it. Could it be possible to have some auto labelling that detect outdated PR ?
   
   honestly, this could have already happened with only a few hours in between the PRs, Its just bad luck tbh. Its all good.
   
   regarding automatic labeling of PRs: maybe, apache projects work with low permissions. I would have to check if writing labels is allowed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on pull request #4586: Fixing error recovery for (current) record patterns.

Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4586:
URL: https://github.com/apache/netbeans/pull/4586#issuecomment-1269954475

   I know merge queues as a service which queues PRs and tests them on master+PR first, if its green it merges with confidence that it will work (it doesn't have to test on master again since it just did).
   But the main reason why they exist is as optimization for big teams, if the queue is full it is going to take a risk and test all PRs at once and if its green merge all at once.
   
   To emulate this with a small team you would simply try to sync the PR short before you merge and you are fine 99% of the time. Thats what we are doing basically. We just got unlucky here and overlooked a PR where tests ran 30 days before merge. I personally wouldn't be worried about this. Development is an imperfect process. If master is red twice a year and we know how to fix it right away its ok in my book ;)
   
   I am just afraid of all the secure token passing between services etc. Always annoying to set this up and thats also the place where vulnerabilities happen.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on pull request #4586: Fixing error recovery for (current) record patterns.

Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4586:
URL: https://github.com/apache/netbeans/pull/4586#issuecomment-1269969298

   another thing worth mentioning. the reason why we didn't notice this right away is because the test failed on travis, and nobody trusts travis to be reliable, so when its red on master not many bother to look since red travis is the default state - green is the exception. 
   
   I only noticed it since we happen to move the job from travis to gh actions and it failed right away even showing the exception trace in the summary which made me happy that this worked :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] ebarboni commented on pull request #4586: Fixing error recovery for (current) record patterns.

Posted by GitBox <gi...@apache.org>.
ebarboni commented on PR #4586:
URL: https://github.com/apache/netbeans/pull/4586#issuecomment-1269535914

   well I see it green, I merged it. Could it be possible to have some auto labelling that detect outdated PR ? 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] ebarboni merged pull request #4586: Fixing error recovery for (current) record patterns.

Posted by GitBox <gi...@apache.org>.
ebarboni merged PR #4586:
URL: https://github.com/apache/netbeans/pull/4586


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] ebarboni commented on pull request #4586: Fixing error recovery for (current) record patterns.

Posted by GitBox <gi...@apache.org>.
ebarboni commented on PR #4586:
URL: https://github.com/apache/netbeans/pull/4586#issuecomment-1264311391

   looks sane + testing will merge soon if nobody complains


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] jlahoda commented on pull request #4586: Fixing error recovery for (current) record patterns.

Posted by GitBox <gi...@apache.org>.
jlahoda commented on PR #4586:
URL: https://github.com/apache/netbeans/pull/4586#issuecomment-1269574548

   I'll take a look in the evening. Sorry for trouble.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on pull request #4586: Fixing error recovery for (current) record patterns.

Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4586:
URL: https://github.com/apache/netbeans/pull/4586#issuecomment-1271332180

   I tested with nb-javac based on jdk 19+36 (local build) and the same test is also failing there.
   Build 36 is the one which got promoted to JDK 19 GA.
   
   @neilcsmith-net correct me if I am wrong but this is one of the releases when we have the option to upgrade nb-javac to a JDK `.1` update release during RC, right? I believe 19.0.1 should be out later this month and that would be also the timeframe when NB is starting its RC cycle.
   
   I was wondering if we should update from 19+33 to 19+36 or wait for 19.0.1.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] neilcsmith-net commented on pull request #4586: Fixing error recovery for (current) record patterns.

Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4586:
URL: https://github.com/apache/netbeans/pull/4586#issuecomment-1269895782

   > honestly, this could have already happened with only a few hours in between the PRs, Its just bad luck tbh
   
   I've noticed people in other ASF projects discussing use of merge queues recently. That might be something to consider here too in all the CI changes?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists