[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #7378: Change the use of the pojson rule

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #7378: Change the use of the pojson rule
URL: https://github.com/apache/incubator-superset/pull/7378#discussion_r278616735
 
 

 ##########
 File path: superset/config.py
 ##########
 @@ -256,8 +256,9 @@
 
 # CSV Options: key/value pairs that will be passed as argument to DataFrame.to_csv method
 # note: index option should not be overridden
+
 CSV_EXPORT = {
-    'encoding': 'utf-8',
+    'encoding': 'utf-8-sig',
 
 Review comment:
   what are the implications of this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org