[GitHub] [incubator-kyuubi] iodone commented on a change in pull request #1682: [KYUUBI #1678] Fixed: The value of hasResultSet is always set to true in Kyuubi Server

[GitBox <gi...@apache.org>]

iodone commented on a change in pull request #1682:
URL: https://github.com/apache/incubator-kyuubi/pull/1682#discussion_r778583573



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/operation/ExecuteStatement.scala
##########
@@ -69,6 +69,7 @@ class ExecuteStatement(
       // in thrift protocol, in sync mode, we cannot distinguish between long-run query and
       // engine crash without response before socket read timeout.
       _remoteOpHandle = client.executeStatement(statement, true, queryTimeout)
+      setHasResultSet(_remoteOpHandle.isHasResultSet)

Review comment:
       https://github.com/apache/incubator-kyuubi/blob/e0d9458144e68411f1dd62afb91efd1e1ef92cc5/kyuubi-common/src/main/scala/org/apache/kyuubi/service/ThriftBinaryFrontendService.scala#L415-L437
   
   There is a unified configuration inside `GetOperationStatus` method, here we only need to change the operation's state
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org