You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by Shiroshica Kulatilake <sh...@wso2.com> on 2015/01/13 06:05:12 UTC
Quite a few old PRs still listed on github Stratos
Hi Devs,
There are 22 pull requests at https://github.com/apache/stratos/pulls
I think most of these have already being merged into the codebase.
Shall we close off those that are already merged ?
Thank you,
Shiro
Re: Quite a few old PRs still listed on github Stratos
Posted by Shiroshica Kulatilake <sh...@wso2.com>.
Great ! and Thank you !
Shiroshica Kulatilake
WSO2, Inc. http://wso2.com/
Phone: +94 776523867
On Tue, Jan 13, 2015 at 12:19 PM, Vishanth Balasubramaniam <
vishanthb@wso2.com> wrote:
> Thanks Shiro for reminding. I closed my merged PR.
>
> On Tue, Jan 13, 2015 at 12:14 PM, Shiroshica Kulatilake <sh...@wso2.com>
> wrote:
>
>> Thank you Gayan and Dakshika !
>>
>>
>> On Tue, Jan 13, 2015 at 11:11 AM, Shiroshica Kulatilake <sh...@wso2.com>
>> wrote:
>>
>>>
>>> On Tue, Jan 13, 2015 at 11:05 AM, Imesh Gunaratne <im...@apache.org>
>>> wrote:
>>>
>>>> AFAIK only the people who opened the PRs can close them.
>>>>
>>> Yes !
>>>
>>>
>>>> Thanks
>>>> On Jan 13, 2015 10:55 AM, "Dakshika Jayathilaka" <da...@wso2.com>
>>>> wrote:
>>>>
>>>>> Hi Shiro,
>>>>>
>>>>> I closed certain merged PR created by me.
>>>>>
>>>>> Thank you,
>>>>>
>>>>> Regards,
>>>>>
>>>>> *Dakshika Jayathilaka*
>>>>> Software Engineer
>>>>> WSO2, Inc.
>>>>> lean.enterprise.middleware
>>>>> 0771100911
>>>>>
>>>>> On Tue, Jan 13, 2015 at 10:35 AM, Shiroshica Kulatilake <
>>>>> shiro@wso2.com> wrote:
>>>>>
>>>>>> Hi Devs,
>>>>>>
>>>>>> There are 22 pull requests at https://github.com/apache/stratos/pulls
>>>>>>
>>>>>> I think most of these have already being merged into the codebase.
>>>>>>
>>>>>> Shall we close off those that are already merged ?
>>>>>>
>>>>>> Thank you,
>>>>>> Shiro
>>>>>>
>>>>>
>>>>>
>>>
>>
>
>
> --
> *Vishanth Balasubramaniam*
> Software Engineer
> WSO2 Inc.; http://wso2.com
> lean.enterprise.middleware
>
> mobile: *+94771737718*
> about me: *http://about.me/vishanth <http://about.me/vishanth>*
>
>
Re: Quite a few old PRs still listed on github Stratos
Posted by Vishanth Balasubramaniam <vi...@wso2.com>.
Thanks Shiro for reminding. I closed my merged PR.
On Tue, Jan 13, 2015 at 12:14 PM, Shiroshica Kulatilake <sh...@wso2.com>
wrote:
> Thank you Gayan and Dakshika !
>
>
> On Tue, Jan 13, 2015 at 11:11 AM, Shiroshica Kulatilake <sh...@wso2.com>
> wrote:
>
>>
>> On Tue, Jan 13, 2015 at 11:05 AM, Imesh Gunaratne <im...@apache.org>
>> wrote:
>>
>>> AFAIK only the people who opened the PRs can close them.
>>>
>> Yes !
>>
>>
>>> Thanks
>>> On Jan 13, 2015 10:55 AM, "Dakshika Jayathilaka" <da...@wso2.com>
>>> wrote:
>>>
>>>> Hi Shiro,
>>>>
>>>> I closed certain merged PR created by me.
>>>>
>>>> Thank you,
>>>>
>>>> Regards,
>>>>
>>>> *Dakshika Jayathilaka*
>>>> Software Engineer
>>>> WSO2, Inc.
>>>> lean.enterprise.middleware
>>>> 0771100911
>>>>
>>>> On Tue, Jan 13, 2015 at 10:35 AM, Shiroshica Kulatilake <shiro@wso2.com
>>>> > wrote:
>>>>
>>>>> Hi Devs,
>>>>>
>>>>> There are 22 pull requests at https://github.com/apache/stratos/pulls
>>>>>
>>>>> I think most of these have already being merged into the codebase.
>>>>>
>>>>> Shall we close off those that are already merged ?
>>>>>
>>>>> Thank you,
>>>>> Shiro
>>>>>
>>>>
>>>>
>>
>
--
*Vishanth Balasubramaniam*
Software Engineer
WSO2 Inc.; http://wso2.com
lean.enterprise.middleware
mobile: *+94771737718*
about me: *http://about.me/vishanth <http://about.me/vishanth>*
Re: Quite a few old PRs still listed on github Stratos
Posted by Shiroshica Kulatilake <sh...@wso2.com>.
Thank you Gayan and Dakshika !
On Tue, Jan 13, 2015 at 11:11 AM, Shiroshica Kulatilake <sh...@wso2.com>
wrote:
>
> On Tue, Jan 13, 2015 at 11:05 AM, Imesh Gunaratne <im...@apache.org>
> wrote:
>
>> AFAIK only the people who opened the PRs can close them.
>>
> Yes !
>
>
>> Thanks
>> On Jan 13, 2015 10:55 AM, "Dakshika Jayathilaka" <da...@wso2.com>
>> wrote:
>>
>>> Hi Shiro,
>>>
>>> I closed certain merged PR created by me.
>>>
>>> Thank you,
>>>
>>> Regards,
>>>
>>> *Dakshika Jayathilaka*
>>> Software Engineer
>>> WSO2, Inc.
>>> lean.enterprise.middleware
>>> 0771100911
>>>
>>> On Tue, Jan 13, 2015 at 10:35 AM, Shiroshica Kulatilake <sh...@wso2.com>
>>> wrote:
>>>
>>>> Hi Devs,
>>>>
>>>> There are 22 pull requests at https://github.com/apache/stratos/pulls
>>>>
>>>> I think most of these have already being merged into the codebase.
>>>>
>>>> Shall we close off those that are already merged ?
>>>>
>>>> Thank you,
>>>> Shiro
>>>>
>>>
>>>
>
Re: Quite a few old PRs still listed on github Stratos
Posted by Shiroshica Kulatilake <sh...@wso2.com>.
On Tue, Jan 13, 2015 at 11:05 AM, Imesh Gunaratne <im...@apache.org> wrote:
> AFAIK only the people who opened the PRs can close them.
>
Yes !
> Thanks
> On Jan 13, 2015 10:55 AM, "Dakshika Jayathilaka" <da...@wso2.com>
> wrote:
>
>> Hi Shiro,
>>
>> I closed certain merged PR created by me.
>>
>> Thank you,
>>
>> Regards,
>>
>> *Dakshika Jayathilaka*
>> Software Engineer
>> WSO2, Inc.
>> lean.enterprise.middleware
>> 0771100911
>>
>> On Tue, Jan 13, 2015 at 10:35 AM, Shiroshica Kulatilake <sh...@wso2.com>
>> wrote:
>>
>>> Hi Devs,
>>>
>>> There are 22 pull requests at https://github.com/apache/stratos/pulls
>>>
>>> I think most of these have already being merged into the codebase.
>>>
>>> Shall we close off those that are already merged ?
>>>
>>> Thank you,
>>> Shiro
>>>
>>
>>
Re: Quite a few old PRs still listed on github Stratos
Posted by Imesh Gunaratne <im...@apache.org>.
AFAIK only the people who opened the PRs can close them.
Thanks
On Jan 13, 2015 10:55 AM, "Dakshika Jayathilaka" <da...@wso2.com> wrote:
> Hi Shiro,
>
> I closed certain merged PR created by me.
>
> Thank you,
>
> Regards,
>
> *Dakshika Jayathilaka*
> Software Engineer
> WSO2, Inc.
> lean.enterprise.middleware
> 0771100911
>
> On Tue, Jan 13, 2015 at 10:35 AM, Shiroshica Kulatilake <sh...@wso2.com>
> wrote:
>
>> Hi Devs,
>>
>> There are 22 pull requests at https://github.com/apache/stratos/pulls
>>
>> I think most of these have already being merged into the codebase.
>>
>> Shall we close off those that are already merged ?
>>
>> Thank you,
>> Shiro
>>
>
>
Re: Quite a few old PRs still listed on github Stratos
Posted by Dakshika Jayathilaka <da...@wso2.com>.
Hi Shiro,
I closed certain merged PR created by me.
Thank you,
Regards,
*Dakshika Jayathilaka*
Software Engineer
WSO2, Inc.
lean.enterprise.middleware
0771100911
On Tue, Jan 13, 2015 at 10:35 AM, Shiroshica Kulatilake <sh...@wso2.com>
wrote:
> Hi Devs,
>
> There are 22 pull requests at https://github.com/apache/stratos/pulls
>
> I think most of these have already being merged into the codebase.
>
> Shall we close off those that are already merged ?
>
> Thank you,
> Shiro
>
Re: Quite a few old PRs still listed on github Stratos
Posted by Gayan Gunarathne <ga...@wso2.com>.
Thanks Shiro for remind this. Yeah there are lot of PR we can close as they
are already merged with the codebase. Will check those and close the
relevant PRs.
Thanks,
Gayan
On Tue, Jan 13, 2015 at 10:35 AM, Shiroshica Kulatilake <sh...@wso2.com>
wrote:
> Hi Devs,
>
> There are 22 pull requests at https://github.com/apache/stratos/pulls
>
> I think most of these have already being merged into the codebase.
>
> Shall we close off those that are already merged ?
>
> Thank you,
> Shiro
>
--
Gayan Gunarathne
Technical Lead
WSO2 Inc. (http://wso2.com)
email : gayang@wso2.com | mobile : +94 766819985