You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/18 12:20:31 UTC
[GitHub] [cloudstack] ravening commented on a change in pull request #3368: server: fix public IP addresses filtering
ravening commented on a change in pull request #3368:
URL: https://github.com/apache/cloudstack/pull/3368#discussion_r526043808
##########
File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java
##########
@@ -1893,7 +1894,8 @@ private boolean hasSuitablePoolsForVolume(final VolumeVO volume, final Host host
sb.and("vlanDbId", sb.entity().getVlanId(), SearchCriteria.Op.EQ);
sb.and("id", sb.entity().getId(), SearchCriteria.Op.EQ);
sb.and("physicalNetworkId", sb.entity().getPhysicalNetworkId(), SearchCriteria.Op.EQ);
- sb.and("associatedNetworkIdEq", sb.entity().getAssociatedWithNetworkId(), SearchCriteria.Op.EQ);
+ sb.and("associatedNetworkId", sb.entity().getAssociatedWithNetworkId(), SearchCriteria.Op.EQ);
+ sb.and("sourceNetworkId", sb.entity().getSourceNetworkId(), SearchCriteria.Op.EQ);
Review comment:
@shwstppr any reason why `sourceNetworkId` is chosen instead of `networkId` parameter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org