You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Wenzhe Zhou (Jira)" <ji...@apache.org> on 2022/01/13 20:19:00 UTC
[jira] [Comment Edited] (IMPALA-10931) Rebase source code under be/src/kudu
[ https://issues.apache.org/jira/browse/IMPALA-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421005#comment-17421005 ]
Wenzhe Zhou edited comment on IMPALA-10931 at 1/13/22, 8:18 PM:
----------------------------------------------------------------
Last rebasing of the source code under be/src/kudu was done with IMPALA-9335. There are two commits for the Jira:
[ https://gerrit.cloudera.org/#/c/15143/|https://gerrit.cloudera.org/#/c/15143/]: Removed be/src/kudu/\{util|security|rpc} and copied back over from Kudu
https://gerrit.cloudera.org/#/c/15144/ : applies various fixes to Impala and to the copied Kudu source code in be/src/kudu/* to allow everything to compile.
We should do rebasing in the same way.
There are several patches which changed the source code in be/src/kudu after IMPALA-9335.
1) Patches which ported some fixes and improvements from Kudu upstream
KUDU-3297 fix RPC negotiations with cyrus-sasl-gssapi-2.1.27-5 and newer
[ IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter|https://github.com/apache/impala/commit/f7770f1d203e1edc24c5f147f4cc4bb56c3e34fc]
[IMPALA-9538 Bump up linux-syscall-support.h|https://github.com/apache/impala/commit/5ff7c6a7de76aac2623710b3e43ceed8ce7424c8]
[ IMPALA-10305: Sync Kudu's FIPS compliant changes|https://github.com/apache/impala/commit/6694d147002c9a713f486a9b58d1db74f0be2e85]
[IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes|https://github.com/apache/impala/commit/4657f062f401a2da5e5f4aa3a3e3244f45dba8c2]
[ IMPALA-10928: Upgrade source of Kudu's EasyCurl in kudu/util|https://github.com/apache/impala/commit/20e07f8645b402f08af91e6b078d1fdd2a0d06f6]
2) Patches with changes uploaded to both Impala and Kudu
[ IMPALA-9359: recover from corrupt kerberos ccache|https://github.com/apache/impala/commit/151754a454c698b4db9bb605a1bcd437c7f1ce9b]
[IMPALA-7504/KUDU-2979 ParseKerberosPrincipal() should use krb5_parse|https://github.com/apache/impala/commit/bb1229411c2b19e1258450e6dc2003f9676ee236]
[IMPALA-6159/KUDU-2192: Enable TCP keepalive for all outbound connection|https://github.com/apache/impala/commit/7206b52e5b6ab1df045e4249d859129d32aacf6b]
IMPALA-9128: part 2: dump traces for slow RPCs
[IMPALA-9565 Remove unused included file mm_malloc.h on ARM|https://github.com/apache/impala/commit/a2e94095a8f8df9432eec857aa6798a61bb2362c]
[IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instruction|https://github.com/apache/impala/commit/6390e7e1da2c02e0dac914348cdd48b9ac2e7126]
KUDU-3297 fix RPC negotiations with cyrus-sasl-gssapi-2.1.27-5 and newer
3) Patches on Impala only
[IMPALA-9182: Print the socket address of the client closing a session…|https://github.com/apache/impala/commit/d96dab20dd663dfdcdcd2771d2f210cb02ecd710#diff-d747655910ba840f4221e978522dd085d1d0b982ddbf69d1819014fc5a82cd19]
[ IMPALA-10779: Print the username closing a session or cancelling a qu…|https://github.com/apache/impala/commit/8a2758f1e88500867d8d2fbaffb62493fca2215a]
[ IMPALA-9940: add missing kudu protobuf deps|https://github.com/apache/impala/commit/dadc3bd61bfb23ad6ef713309b79f9c7bd9b4909]
[Limit short versions of KUDU_* macros to Kudu source.|https://github.com/apache/impala/commit/d9a38c0bac70f0cf552855183d73daf53aa09ef6#diff-33cb7d670324f434a724cd72f7a12f24e0fb1bfac4a94d91da76925299edf394]
We need to reapply [https://gerrit.cloudera.org/#/c/15144/] and patches in 3) on the copied latest source code in be/src/kudu.
was (Author: wzhou):
Last rebasing of the source code under be/src/kudu was done with IMPALA-9335. There are two commits for the Jira:
[ https://gerrit.cloudera.org/#/c/15143/|https://gerrit.cloudera.org/#/c/15143/]: Removed be/src/kudu/\{util|security|rpc} and copied back over from Kudu
https://gerrit.cloudera.org/#/c/15144/ : applies various fixes to Impala and to the copied Kudu source code in be/src/kudu/* to allow everything to compile.
We should do rebasing in the same way.
There are several patches which changed the source code in be/src/kudu after IMPALA-9335.
1) Patches which ported some fixes and improvements from Kudu upstream
KUDU-3297 fix RPC negotiations with cyrus-sasl-gssapi-2.1.27-5 and newer
[ IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter|https://github.com/apache/impala/commit/f7770f1d203e1edc24c5f147f4cc4bb56c3e34fc]
[IMPALA-9538 Bump up linux-syscall-support.h|https://github.com/apache/impala/commit/5ff7c6a7de76aac2623710b3e43ceed8ce7424c8]
[ IMPALA-10305: Sync Kudu's FIPS compliant changes|https://github.com/apache/impala/commit/6694d147002c9a713f486a9b58d1db74f0be2e85]
[IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes|https://github.com/apache/impala/commit/4657f062f401a2da5e5f4aa3a3e3244f45dba8c2]
[ IMPALA-10928: Upgrade source of Kudu's EasyCurl in kudu/util|https://github.com/apache/impala/commit/20e07f8645b402f08af91e6b078d1fdd2a0d06f6]
2) Patches with changes uploaded to both Impala and Kudu
[ IMPALA-9359: recover from corrupt kerberos ccache|https://github.com/apache/impala/commit/151754a454c698b4db9bb605a1bcd437c7f1ce9b]
[IMPALA-7504/KUDU-2979 ParseKerberosPrincipal() should use krb5_parse|https://github.com/apache/impala/commit/bb1229411c2b19e1258450e6dc2003f9676ee236]
[IMPALA-6159/KUDU-2192: Enable TCP keepalive for all outbound connection|https://github.com/apache/impala/commit/7206b52e5b6ab1df045e4249d859129d32aacf6b]
IMPALA-9128: part 2: dump traces for slow RPCs
[IMPALA-9565 Remove unused included file mm_malloc.h on ARM|https://github.com/apache/impala/commit/a2e94095a8f8df9432eec857aa6798a61bb2362c]
[IMPALA-9544 Replace Intel's SSE instructions with ARM's NEON instruction|https://github.com/apache/impala/commit/6390e7e1da2c02e0dac914348cdd48b9ac2e7126]
3) Patches on Impala only
[IMPALA-9182: Print the socket address of the client closing a session…|https://github.com/apache/impala/commit/d96dab20dd663dfdcdcd2771d2f210cb02ecd710#diff-d747655910ba840f4221e978522dd085d1d0b982ddbf69d1819014fc5a82cd19]
[ IMPALA-10779: Print the username closing a session or cancelling a qu…|https://github.com/apache/impala/commit/8a2758f1e88500867d8d2fbaffb62493fca2215a]
[ IMPALA-9940: add missing kudu protobuf deps|https://github.com/apache/impala/commit/dadc3bd61bfb23ad6ef713309b79f9c7bd9b4909]
[Limit short versions of KUDU_* macros to Kudu source.|https://github.com/apache/impala/commit/d9a38c0bac70f0cf552855183d73daf53aa09ef6#diff-33cb7d670324f434a724cd72f7a12f24e0fb1bfac4a94d91da76925299edf394]
We need to reapply [https://gerrit.cloudera.org/#/c/15144/] and patches in 3) on the copied latest source code in be/src/kudu.
> Rebase source code under be/src/kudu
> ------------------------------------
>
> Key: IMPALA-10931
> URL: https://issues.apache.org/jira/browse/IMPALA-10931
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Reporter: Wenzhe Zhou
> Assignee: Wenzhe Zhou
> Priority: Major
> Fix For: Impala 4.1.0
>
>
> Impala pulls KRPC in by copying and pasting several directories from Kudu's source code (/rpc, /util, and /security). This code has not been updated in more than a year and half. There are various fixes and improvements that have been made on the Kudu side, like supporting TLS v1.3 in KRPC. It would be nice to pull in all these improvements.
> There are a few patches which we made on the copied source code in be/src/kudu. We need to make sure that all those patches are incorporated or maintained when rebase be/src/kudu.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org