You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Harish Butani <rh...@gmail.com> on 2014/02/04 04:39:21 UTC

Review Request 17691: Support Common Table Expressions (CTEs) in Hive

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17691/
-----------------------------------------------------------

Review request for hive and Gunther Hagleitner.


Bugs: HIVE-1180
    https://issues.apache.org/jira/browse/HIVE-1180


Repository: hive-git


Description
-------

Support Common Table Expressions (CTEs) in Hive


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 17f3552 
  ql/src/java/org/apache/hadoop/hive/ql/parse/QB.java 3fbe8e2 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 719b496 
  ql/src/test/queries/clientnegative/cte_recursion.q PRE-CREATION 
  ql/src/test/queries/clientnegative/cte_with_in_subquery.q PRE-CREATION 
  ql/src/test/queries/clientpositive/cte_1.q PRE-CREATION 
  ql/src/test/queries/clientpositive/cte_2.q PRE-CREATION 
  ql/src/test/results/clientnegative/cte_recursion.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/cte_with_in_subquery.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/cte_1.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/cte_2.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/17691/diff/


Testing
-------

added new tests


Thanks,

Harish Butani

Re: Review Request 17691: Support Common Table Expressions (CTEs) in Hive

Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17691/#review33656
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
<https://reviews.apache.org/r/17691/#comment63209>

    lots of trailing ws in this patch which needs to be cleaned up


- Brock Noland


On Feb. 4, 2014, 10:56 p.m., Harish Butani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17691/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 10:56 p.m.)
> 
> 
> Review request for hive and Gunther Hagleitner.
> 
> 
> Bugs: HIVE-1180
>     https://issues.apache.org/jira/browse/HIVE-1180
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Support Common Table Expressions (CTEs) in Hive
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 17f3552 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/QB.java 3fbe8e2 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 59987e3 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java 4ac8f07 
>   ql/src/test/queries/clientnegative/cte_recursion.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/cte_with_in_subquery.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/cte_1.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/cte_2.q PRE-CREATION 
>   ql/src/test/results/clientnegative/authorization_invalid_priv_v1.q.out 431f16e 
>   ql/src/test/results/clientnegative/cte_recursion.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/cte_with_in_subquery.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cte_1.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cte_2.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17691/diff/
> 
> 
> Testing
> -------
> 
> added new tests
> 
> 
> Thanks,
> 
> Harish Butani
> 
>

Re: Review Request 17691: Support Common Table Expressions (CTEs) in Hive

Posted by Harish Butani <rh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17691/
-----------------------------------------------------------

(Updated Feb. 5, 2014, 2:24 a.m.)


Review request for hive and Gunther Hagleitner.


Changes
-------

add comma in grammar


Bugs: HIVE-1180
    https://issues.apache.org/jira/browse/HIVE-1180


Repository: hive-git


Description
-------

Support Common Table Expressions (CTEs) in Hive


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 17f3552 
  ql/src/java/org/apache/hadoop/hive/ql/parse/QB.java 3fbe8e2 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 59987e3 
  ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java 4ac8f07 
  ql/src/test/queries/clientnegative/cte_recursion.q PRE-CREATION 
  ql/src/test/queries/clientnegative/cte_with_in_subquery.q PRE-CREATION 
  ql/src/test/queries/clientpositive/cte_1.q PRE-CREATION 
  ql/src/test/queries/clientpositive/cte_2.q PRE-CREATION 
  ql/src/test/results/clientnegative/authorization_invalid_priv_v1.q.out 431f16e 
  ql/src/test/results/clientnegative/cte_recursion.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/cte_with_in_subquery.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/cte_1.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/cte_2.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/17691/diff/


Testing
-------

added new tests


Thanks,

Harish Butani

Re: Review Request 17691: Support Common Table Expressions (CTEs) in Hive

Posted by Harish Butani <rh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17691/
-----------------------------------------------------------

(Updated Feb. 4, 2014, 11:26 p.m.)


Review request for hive and Gunther Hagleitner.


Changes
-------

fix ws 


Bugs: HIVE-1180
    https://issues.apache.org/jira/browse/HIVE-1180


Repository: hive-git


Description
-------

Support Common Table Expressions (CTEs) in Hive


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 17f3552 
  ql/src/java/org/apache/hadoop/hive/ql/parse/QB.java 3fbe8e2 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 59987e3 
  ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java 4ac8f07 
  ql/src/test/queries/clientnegative/cte_recursion.q PRE-CREATION 
  ql/src/test/queries/clientnegative/cte_with_in_subquery.q PRE-CREATION 
  ql/src/test/queries/clientpositive/cte_1.q PRE-CREATION 
  ql/src/test/queries/clientpositive/cte_2.q PRE-CREATION 
  ql/src/test/results/clientnegative/authorization_invalid_priv_v1.q.out 431f16e 
  ql/src/test/results/clientnegative/cte_recursion.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/cte_with_in_subquery.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/cte_1.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/cte_2.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/17691/diff/


Testing
-------

added new tests


Thanks,

Harish Butani

Re: Review Request 17691: Support Common Table Expressions (CTEs) in Hive

Posted by Harish Butani <rh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17691/
-----------------------------------------------------------

(Updated Feb. 4, 2014, 10:56 p.m.)


Review request for hive and Gunther Hagleitner.


Bugs: HIVE-1180
    https://issues.apache.org/jira/browse/HIVE-1180


Repository: hive-git


Description
-------

Support Common Table Expressions (CTEs) in Hive


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 17f3552 
  ql/src/java/org/apache/hadoop/hive/ql/parse/QB.java 3fbe8e2 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 59987e3 
  ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java 4ac8f07 
  ql/src/test/queries/clientnegative/cte_recursion.q PRE-CREATION 
  ql/src/test/queries/clientnegative/cte_with_in_subquery.q PRE-CREATION 
  ql/src/test/queries/clientpositive/cte_1.q PRE-CREATION 
  ql/src/test/queries/clientpositive/cte_2.q PRE-CREATION 
  ql/src/test/results/clientnegative/authorization_invalid_priv_v1.q.out 431f16e 
  ql/src/test/results/clientnegative/cte_recursion.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/cte_with_in_subquery.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/cte_1.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/cte_2.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/17691/diff/


Testing
-------

added new tests


Thanks,

Harish Butani

Re: Review Request 17691: Support Common Table Expressions (CTEs) in Hive

Posted by Harish Butani <rh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17691/
-----------------------------------------------------------

(Updated Feb. 4, 2014, 10:56 p.m.)


Review request for hive and Gunther Hagleitner.


Changes
-------

addressed review comments


Bugs: HIVE-1180
    https://issues.apache.org/jira/browse/HIVE-1180


Repository: hive-git


Description
-------

Support Common Table Expressions (CTEs) in Hive


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 17f3552 
  ql/src/java/org/apache/hadoop/hive/ql/parse/QB.java 3fbe8e2 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 59987e3 
  ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java 4ac8f07 
  ql/src/test/queries/clientnegative/cte_recursion.q PRE-CREATION 
  ql/src/test/queries/clientnegative/cte_with_in_subquery.q PRE-CREATION 
  ql/src/test/queries/clientpositive/cte_1.q PRE-CREATION 
  ql/src/test/queries/clientpositive/cte_2.q PRE-CREATION 
  ql/src/test/results/clientnegative/authorization_invalid_priv_v1.q.out 431f16e 
  ql/src/test/results/clientnegative/cte_recursion.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/cte_with_in_subquery.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/cte_1.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/cte_2.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/17691/diff/


Testing
-------

added new tests


Thanks,

Harish Butani

Re: Review Request 17691: Support Common Table Expressions (CTEs) in Hive

Posted by Harish Butani <rh...@gmail.com>.

> On Feb. 4, 2014, 9:23 a.m., Gunther Hagleitner wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g, line 1935
> > <https://reviews.apache.org/r/17691/diff/1/?file=463839#file463839line1935>
> >
> >     i thought multiple ctes are comma separated, no?

we are already using parentheses to wrap the query, comma is not needed


> On Feb. 4, 2014, 9:23 a.m., Gunther Hagleitner wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 8992
> > <https://reviews.apache.org/r/17691/diff/1/?file=463841#file463841line8992>
> >
> >     shouldn't views/ctesExpanded be sets?

it needs order; viewsExpanded working the same way....


- Harish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17691/#review33573
-----------------------------------------------------------


On Feb. 4, 2014, 10:56 p.m., Harish Butani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17691/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 10:56 p.m.)
> 
> 
> Review request for hive and Gunther Hagleitner.
> 
> 
> Bugs: HIVE-1180
>     https://issues.apache.org/jira/browse/HIVE-1180
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Support Common Table Expressions (CTEs) in Hive
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 17f3552 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/QB.java 3fbe8e2 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 59987e3 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java 4ac8f07 
>   ql/src/test/queries/clientnegative/cte_recursion.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/cte_with_in_subquery.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/cte_1.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/cte_2.q PRE-CREATION 
>   ql/src/test/results/clientnegative/authorization_invalid_priv_v1.q.out 431f16e 
>   ql/src/test/results/clientnegative/cte_recursion.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/cte_with_in_subquery.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cte_1.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cte_2.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17691/diff/
> 
> 
> Testing
> -------
> 
> added new tests
> 
> 
> Thanks,
> 
> Harish Butani
> 
>

Re: Review Request 17691: Support Common Table Expressions (CTEs) in Hive

Posted by Gunther Hagleitner <gh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17691/#review33573
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
<https://reviews.apache.org/r/17691/#comment63113>

    i thought multiple ctes are comma separated, no?



ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/17691/#comment63106>

    nit: you already have currDB to get the length.



ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/17691/#comment63107>

    i think having a comment for this block would be nice. i don't know what all is in qId. since you're trying multiple names is there a chance of collision?



ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/17691/#comment63109>

    nit: spaces



ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/17691/#comment63110>

    shouldn't views/ctesExpanded be sets?



ql/src/test/results/clientnegative/cte_recursion.q.out
<https://reviews.apache.org/r/17691/#comment63111>

    i like the error message. neat.


- Gunther Hagleitner


On Feb. 4, 2014, 3:39 a.m., Harish Butani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17691/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 3:39 a.m.)
> 
> 
> Review request for hive and Gunther Hagleitner.
> 
> 
> Bugs: HIVE-1180
>     https://issues.apache.org/jira/browse/HIVE-1180
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Support Common Table Expressions (CTEs) in Hive
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 17f3552 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/QB.java 3fbe8e2 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 719b496 
>   ql/src/test/queries/clientnegative/cte_recursion.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/cte_with_in_subquery.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/cte_1.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/cte_2.q PRE-CREATION 
>   ql/src/test/results/clientnegative/cte_recursion.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/cte_with_in_subquery.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cte_1.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cte_2.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17691/diff/
> 
> 
> Testing
> -------
> 
> added new tests
> 
> 
> Thanks,
> 
> Harish Butani
> 
>