[GitHub] [spark] srowen commented on a change in pull request #24147: [SPARK-27205][CORE] Avoid initializing "object class" named "$" while initializing mainClass in SparkSubmit

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #24147: [SPARK-27205][CORE] Avoid initializing "object class" named "<clazz>$" while initializing mainClass in SparkSubmit
URL: https://github.com/apache/spark/pull/24147#discussion_r267049670
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/util/Utils.scala
 ##########
 @@ -201,6 +201,13 @@ private[spark] object Utils extends Logging {
     // scalastyle:on classforname
   }
 
+  // scalastyle:off classforname
+  /** Preferred alternative to Class.forName(className, initialize, classloader) */
+  def classForName(className: String, initialize: Boolean): Class[_] = {
 
 Review comment:
   Just modify the existing method to take an optional param?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org