You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/05 05:38:16 UTC
[GitHub] [incubator-nuttx-apps] masayuki2009 opened a new pull request #285: system: nxplayer: Refactor nxplayer.c
masayuki2009 opened a new pull request #285:
URL: https://github.com/apache/incubator-nuttx-apps/pull/285
## Summary
- This PR removes redundant code regarding audio buffer configuration in nxplayer.c
- In previous implementation, there were many #ifdef CONFIG_AUDIO_DRIVER_SPECIFIC_BUFFERS which resulted in complicated code.
- This PR simplifies nxplayer.c which ** always ** calls ioctl() to the nuttx audio driver to obtain buffer configurations and stores the information to buf_info. If ioctl() failed which means that underlying audio driver does not support 'audio driver specific buffers', then use default values such as CONFIG_AUDIO_BUFFER_NUMBYTES and CONFIG_AUDIO_NUM_BUFFERS
## Impact
- This PR affects nxplayer
## Testing
- I tested this PR with both spresense which has CONFIG_AUDIO_DRIVER_SPECIFIC_BUFFERS=y and lc823450-xgevk which ** does not ** have CONFIG_AUDIO_DRIVER_SPECIFIC_BUFFERS=y
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #285: system: nxplayer: Refactor nxplayer.c
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #285:
URL: https://github.com/apache/incubator-nuttx-apps/pull/285#issuecomment-639305550
LGTM, nxrecorder can do the same improvement too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #285: system: nxplayer: Refactor nxplayer.c
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #285:
URL: https://github.com/apache/incubator-nuttx-apps/pull/285
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org