You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by ppoulosk <gi...@git.apache.org> on 2016/09/13 21:29:45 UTC

[GitHub] storm pull request #1684: [STORM-2093] Fix permissions in multi-tenant, secu...

GitHub user ppoulosk opened a pull request:

    https://github.com/apache/storm/pull/1684

    [STORM-2093] Fix permissions in multi-tenant, secure mode

    Heap dumps created on OOM, when served through the logviewer in secure multitenant configurations have permssions set such that the logviewer cannot read them.
    
    This change checks permissions in this case before serving and then runs the worker-launcher to enable the logviewer to serve them.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ppoulosk/storm STORM-2093

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1684.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1684
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1684: [STORM-2093] Fix permissions in multi-tenant, secure mode

Posted by revans2 <gi...@git.apache.org>.

Github user revans2 commented on the issue:

    https://github.com/apache/storm/pull/1684
  
    I agree with @HeartSaVioR could you please change the commit message to something more like the pull request title?
    
    ```
    git commit --amend
    ```
    
    should do it for you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1684: [STORM-2093] Fix permissions in multi-tenant, secure mode

Posted by ppoulosk <gi...@git.apache.org>.

Github user ppoulosk commented on the issue:

    https://github.com/apache/storm/pull/1684
  
    Sorry it's taken me so long to get back to this, @HeartSaVioR @revans2.  Amended commit message.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1684: [STORM-2093] Fix permissions in multi-tenant, secu...

Posted by ppoulosk <gi...@git.apache.org>.

Github user ppoulosk closed the pull request at:

    https://github.com/apache/storm/pull/1684


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1684: [STORM-2093] Fix permissions in multi-tenant, secure mode

Posted by ppoulosk <gi...@git.apache.org>.

Github user ppoulosk commented on the issue:

    https://github.com/apache/storm/pull/1684
  
    screwed up merge.  Closing.  It'll be easier to do this on a fresh branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1684: [STORM-2093] Fix permissions in multi-tenant, secure mode

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/1684
  
    Any updates here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1684: [STORM-2093] Fix permissions in multi-tenant, secure mode

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/1684
  
    Please make commit message explain the commit and/or add JIRA issue as prefix. Commit message is not clear on which thing this commit fixes and how it helps.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---