You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jens-G (via GitHub)" <gi...@apache.org> on 2026/05/19 23:14:09 UTC
[PR] THRIFT-6013: Add recursion depth limit to skip() in Ruby library [thrift]
Jens-G opened a new pull request, #3499:
URL: https://github.com/apache/thrift/pull/3499
## Summary
- Adds a `max_depth` parameter (default 64) to `BaseProtocol#skip`
- Raises `ProtocolException::DEPTH_LIMIT` when the depth limit is exceeded
- Aligns the Ruby implementation with Java, Python, Go and netstd, which already enforce this limit
- Adds two unit tests to `base_protocol_spec.rb` covering the limit boundary
## Test plan
- [ ] `spec/base_protocol_spec.rb` — new tests: raises `DEPTH_LIMIT` at `max_depth=0`, no raise at `max_depth=1` for a leaf type
- [ ] Existing skip tests (`should skip structs/maps/sets/lists`) continue to pass
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-6013: Add recursion depth limit to skip() in Ruby library [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G merged PR #3499:
URL: https://github.com/apache/thrift/pull/3499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org