You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/10/01 21:55:50 UTC
Review Request 26244: Add a doc about dedicated hosts.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26244/
-----------------------------------------------------------
Review request for Aurora.
Bugs: AURORA-703
https://issues.apache.org/jira/browse/AURORA-703
Repository: aurora
Description
-------
Add a doc about dedicated hosts.
Diffs
-----
docs/deploying-aurora-scheduler.md 93ff746038df14f2abeea85acf48d02b217af522
Diff: https://reviews.apache.org/r/26244/diff/
Testing
-------
Rendered here: https://github.com/wfarner/incubator-aurora/blob/wfarner/doc_dedicated_machines/docs/deploying-aurora-scheduler.md
Thanks,
Bill Farner
Re: Review Request 26244: Add a doc about dedicated hosts.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26244/#review55294
-----------------------------------------------------------
Kevin - ping?
- Bill Farner
On Oct. 2, 2014, 2:25 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26244/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 2:25 a.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-703
> https://issues.apache.org/jira/browse/AURORA-703
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a doc about dedicated hosts.
>
>
> Diffs
> -----
>
> docs/deploying-aurora-scheduler.md 93ff746038df14f2abeea85acf48d02b217af522
>
> Diff: https://reviews.apache.org/r/26244/diff/
>
>
> Testing
> -------
>
> Rendered here: https://github.com/wfarner/incubator-aurora/blob/wfarner/doc_dedicated_machines/docs/deploying-aurora-scheduler.md
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 26244: Add a doc about dedicated hosts.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26244/#review55296
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Oct. 1, 2014, 7:25 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26244/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2014, 7:25 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-703
> https://issues.apache.org/jira/browse/AURORA-703
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a doc about dedicated hosts.
>
>
> Diffs
> -----
>
> docs/deploying-aurora-scheduler.md 93ff746038df14f2abeea85acf48d02b217af522
>
> Diff: https://reviews.apache.org/r/26244/diff/
>
>
> Testing
> -------
>
> Rendered here: https://github.com/wfarner/incubator-aurora/blob/wfarner/doc_dedicated_machines/docs/deploying-aurora-scheduler.md
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 26244: Add a doc about dedicated hosts.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26244/
-----------------------------------------------------------
(Updated Oct. 2, 2014, 2:25 a.m.)
Review request for Aurora and Kevin Sweeney.
Changes
-------
Added an explicit section about dedicated attribute syntax.
Bugs: AURORA-703
https://issues.apache.org/jira/browse/AURORA-703
Repository: aurora
Description
-------
Add a doc about dedicated hosts.
Diffs (updated)
-----
docs/deploying-aurora-scheduler.md 93ff746038df14f2abeea85acf48d02b217af522
Diff: https://reviews.apache.org/r/26244/diff/
Testing
-------
Rendered here: https://github.com/wfarner/incubator-aurora/blob/wfarner/doc_dedicated_machines/docs/deploying-aurora-scheduler.md
Thanks,
Bill Farner
Re: Review Request 26244: Add a doc about dedicated hosts.
Posted by Bill Farner <wf...@apache.org>.
> On Oct. 2, 2014, 12:48 a.m., Jay Buffington wrote:
> > docs/deploying-aurora-scheduler.md, line 155
> > <https://reviews.apache.org/r/26244/diff/1/?file=710319#file710319line155>
> >
> > Before the example I think you should have a more formal definition of the value for the dedicated attribute.
> >
> > I think what you're saying here is that the format is $role/$job_name. Do I *have* to include job name? What if I want to dedicate a slave to a role rather than a role + job.
> >
> > I assume environment cannot go into the value for dedicated.
Sure thing, thanks for chiming in! Done.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26244/#review55171
-----------------------------------------------------------
On Oct. 2, 2014, 12:09 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26244/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 12:09 a.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-703
> https://issues.apache.org/jira/browse/AURORA-703
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a doc about dedicated hosts.
>
>
> Diffs
> -----
>
> docs/deploying-aurora-scheduler.md 93ff746038df14f2abeea85acf48d02b217af522
>
> Diff: https://reviews.apache.org/r/26244/diff/
>
>
> Testing
> -------
>
> Rendered here: https://github.com/wfarner/incubator-aurora/blob/wfarner/doc_dedicated_machines/docs/deploying-aurora-scheduler.md
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 26244: Add a doc about dedicated hosts.
Posted by Jay Buffington <me...@jaybuff.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26244/#review55171
-----------------------------------------------------------
docs/deploying-aurora-scheduler.md
<https://reviews.apache.org/r/26244/#comment95556>
Before the example I think you should have a more formal definition of the value for the dedicated attribute.
I think what you're saying here is that the format is $role/$job_name. Do I *have* to include job name? What if I want to dedicate a slave to a role rather than a role + job.
I assume environment cannot go into the value for dedicated.
Thanks so much for writing this!
- Jay Buffington
On Oct. 2, 2014, 12:09 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26244/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 12:09 a.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-703
> https://issues.apache.org/jira/browse/AURORA-703
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a doc about dedicated hosts.
>
>
> Diffs
> -----
>
> docs/deploying-aurora-scheduler.md 93ff746038df14f2abeea85acf48d02b217af522
>
> Diff: https://reviews.apache.org/r/26244/diff/
>
>
> Testing
> -------
>
> Rendered here: https://github.com/wfarner/incubator-aurora/blob/wfarner/doc_dedicated_machines/docs/deploying-aurora-scheduler.md
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 26244: Add a doc about dedicated hosts.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26244/
-----------------------------------------------------------
(Updated Oct. 2, 2014, 12:09 a.m.)
Review request for Aurora and Kevin Sweeney.
Changes
-------
Whoops, forgot to add a reviewer.
Bugs: AURORA-703
https://issues.apache.org/jira/browse/AURORA-703
Repository: aurora
Description
-------
Add a doc about dedicated hosts.
Diffs
-----
docs/deploying-aurora-scheduler.md 93ff746038df14f2abeea85acf48d02b217af522
Diff: https://reviews.apache.org/r/26244/diff/
Testing
-------
Rendered here: https://github.com/wfarner/incubator-aurora/blob/wfarner/doc_dedicated_machines/docs/deploying-aurora-scheduler.md
Thanks,
Bill Farner