You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2021/04/26 02:59:25 UTC

[GitHub] [daffodil] mbeckerle commented on a change in pull request #539: Fix TCP/network input stream hangs on isAtEnd

mbeckerle commented on a change in pull request #539:
URL: https://github.com/apache/daffodil/pull/539#discussion_r619942124



##########
File path: daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala
##########
@@ -837,7 +837,9 @@ case class ParserTestCase(ptc: NodeSeq, parentArg: DFDLTestSuite)
     roundTrip: RoundTrip,
     implString: Option[String]) = {
 
-    val nBits = optLengthLimitInBits.get
+    val nBits = optLengthLimitInBits.getOrElse{
+      Assert.invariantFailed("TDML tests should always have a length limit.")

Review comment:
       Change to a plain 
   `Assert.usage(optLengthLimitInBits.isDefined)` will make the coverage error go away. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org