[GitHub] [ozone] errose28 commented on pull request #3362: Revert "HDDS-5740. Enable ratis by default for SCM."

[GitBox <gi...@apache.org>]

errose28 commented on PR #3362:
URL: https://github.com/apache/ozone/pull/3362#issuecomment-1112620531

   When upgrading from an old version to a version supporting SCM HA, none of the SCM HA configs are allowed to be turned on to prevent writing incompatible data before finalization. What happened with the original change was when a non-Ratis SCM was upgraded to a version supporting SCM HA, the ratis enabled flag was automatically set to true. The upgrade framework stopped this before any changes could be made, hence all pre-SCM HA clusters upgraded will fail immediately on startup with the message: `Configuration ozone.scm.ratis.enable cannot be used until SCM upgrade has been finalized`.
   For the user to proceed, the config must be manually set to true and the cluster restarted, poor experience IMO. The upgrade acceptance tests correctly flagged this as incompatible, but they were modified in the original PR to mask the issue.
   
   I am +1 for reverting the change for now to get the incompatibility out of master. However, I see @mukul1987's point that for new clusters, at least 1 node Ratis for SCM would be the preferred default. I think we can come up with a way to do this in a follow-up PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org