You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/29 18:34:23 UTC

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4251: raspberrypi-pico: add support for lcd_dev

gustavonihei commented on a change in pull request #4251:
URL: https://github.com/apache/incubator-nuttx/pull/4251#discussion_r679394402



##########
File path: boards/arm/rp2040/raspberrypi-pico/src/rp2040_bringup.c
##########
@@ -136,6 +144,20 @@ int rp2040_bringup(void)
     {
       _err("ERROR: Failed to initialize Frame Buffer Driver.\n");
     }
+#elif defined(CONFIG_LCD)
+  ret = board_lcd_initialize();
+  if (ret < 0)
+    {
+      syslog(LOG_ERR, "ERROR: Failed to initialize ST7789 Driver.\n");

Review comment:
       It does not seem right to restrict the error log to a specific driver here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org