You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by sj...@apache.org on 2024/12/23 21:09:54 UTC
(maven-changes-plugin) 01/01: [MCHANGES-456] Make dev attribute optional in changes.xml
This is an automated email from the ASF dual-hosted git repository.
sjaranowski pushed a commit to branch MCHANGES-456
in repository https://gitbox.apache.org/repos/asf/maven-changes-plugin.git
commit d5c4e3f23ed4a66a59c7da3b3c21b662ff84a085
Author: Slawomir Jaranowski <s....@gmail.com>
AuthorDate: Mon Dec 23 22:09:29 2024 +0100
[MCHANGES-456] Make dev attribute optional in changes.xml
---
src/it/report-changes-generation/src/changes/changes.xml | 1 +
src/it/report-changes-generation/verify.groovy | 2 ++
.../java/org/apache/maven/plugins/changes/ChangesReportRenderer.java | 2 +-
src/main/mdo/changes.mdo | 2 +-
4 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/it/report-changes-generation/src/changes/changes.xml b/src/it/report-changes-generation/src/changes/changes.xml
index 75a697b..3596a1d 100644
--- a/src/it/report-changes-generation/src/changes/changes.xml
+++ b/src/it/report-changes-generation/src/changes/changes.xml
@@ -48,6 +48,7 @@ under the License.
due-to="John Doe,John Doe" due-to-email="john@doe.com">
Updated dependencies.
</action>
+ <action type="update">No dev action</action>
</release>
<release version="1.0" date="2005-01-01" description="First release">
diff --git a/src/it/report-changes-generation/verify.groovy b/src/it/report-changes-generation/verify.groovy
index 2ffa67e..669f6e4 100644
--- a/src/it/report-changes-generation/verify.groovy
+++ b/src/it/report-changes-generation/verify.groovy
@@ -38,3 +38,5 @@ assert !content.contains('Fixes .'): 'changes.html doesn\'t handle empty fixes a
assert content.contains('<a class="externalLink" href="mailto:john@doe.com">John Doe</a>')
assert content.contains('Thanks to External Submitter,')
assert content.contains('<a class="externalLink" href="mailto:others@users.com">others</a>')
+// no link to empty dev value
+assert content.contains('<td>-</td></tr>')
diff --git a/src/main/java/org/apache/maven/plugins/changes/ChangesReportRenderer.java b/src/main/java/org/apache/maven/plugins/changes/ChangesReportRenderer.java
index 3e7d393..555dddf 100644
--- a/src/main/java/org/apache/maven/plugins/changes/ChangesReportRenderer.java
+++ b/src/main/java/org/apache/maven/plugins/changes/ChangesReportRenderer.java
@@ -193,7 +193,7 @@ public class ChangesReportRenderer extends AbstractIssuesReportRenderer {
sink.tableCell_();
- if (NO_TEAM.equals(team)) {
+ if (NO_TEAM.equals(team) || action.getDev() == null || action.getDev().isEmpty()) {
sinkCell(action.getDev());
} else {
sinkCellLink(action.getDev(), team + "#" + action.getDev());
diff --git a/src/main/mdo/changes.mdo b/src/main/mdo/changes.mdo
index fd8bcb7..fcb7516 100644
--- a/src/main/mdo/changes.mdo
+++ b/src/main/mdo/changes.mdo
@@ -227,8 +227,8 @@ under the License.
<field xml.attribute="true">
<name>dev</name>
<version>1.0.0+</version>
- <required>true</required>
<type>String</type>
+ <defaultValue/>
<description>
<![CDATA[
Name of developer who committed the change.